diff options
author | mtklein <mtklein@chromium.org> | 2016-08-24 12:23:52 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-08-24 12:23:52 -0700 |
commit | c095df55e86e7126b0582856720bb9177b553ff1 (patch) | |
tree | 7d4823265c729beb4e44bd115cbd00c70085339b /include/config | |
parent | 6dc5b9a9b79b9d71e772c47a4346fde31f3e7bfb (diff) |
GN: guard tools (except fiddle) by skia_enable_tools.
Our tools use third-party libraries pretty freely, some of which may not
be available in other GN environments (e.g. Fuchsia). Most can also not
function when Skia is built as a shared library.
fiddle stands alone as the exception to both those points: it depends on
only Skia, and works fine with both a shared or static library.
So guard everything but fiddle with this flag skia_enable_tools, disabled
when we're building for Fuchsia or when we're build a shared library.
This CL has a couple of little tweaks to Fiddle to keep it working:
- divorce it from :tool_utils, instead just building SkForceLinking.cpp itself;
- fix up a buggy rebase_path() that was accidentally working when we depended
on :tool_utils;
- drop test_only: it now only requires production-code dependencies.
The SkImageEncoder Create* methods need to be SK_API if we want SkForceLinking
to work across .so's. Without this, SkForceLinking needs to be part of Skia; it
can't be part of the application using Skia.
The rest is mostly just a re-indent under if (skia_enable_tools),
courtesy of gn format.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2273823003
No public API changes.
TBR=reed@google.com
Review-Url: https://codereview.chromium.org/2273823003
Diffstat (limited to 'include/config')
0 files changed, 0 insertions, 0 deletions