diff options
| author |  mtklein <mtklein@chromium.org> | 2015-02-05 09:23:56 -0800 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2015-02-05 09:23:57 -0800 |
| commit | f3cdce79103558c4136cc6e8b04d50a0b0f04eb4 (patch) | |
| tree | ddf3bf8c50751f4ba98ffd02d3787f39a6586111 /gyp | |
| parent | 8d9225ba78c05194fdffc05ee8bdd5c15b7367ff (diff) | |
Build in C++11 mode on Unix-like bots.
Mac and Windows bots are already building in C++11 mode.
This turns on the rest, mostly to see what work remains.
This will probably break a few bots. It'd be nice if we could let those
all come in as red before reverting this so I can see the full list to fix.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/779e49602a9c8f4d2799504822e01bcafbcaa534
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu13.10-GCC4.8-NaCl-Release-Trybot,Build-Mac10.7-Clang-Arm7-Debug-iOS-Trybot
Review URL: https://codereview.chromium.org/868233008
Diffstat (limited to 'gyp')
| -rw-r--r-- | gyp/common_conditions.gypi | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi index 27dbf2a0e9..15db2a61e8 100644 --- a/gyp/common_conditions.gypi +++ b/gyp/common_conditions.gypi @@ -216,10 +216,10 @@ '-Wpointer-arith', '-Wsign-compare', - '-Wno-c++11-extensions', '-Wno-unused-parameter', ], 'cflags_cc': [ + '-std=c++11', '-fno-rtti', '-Wnon-virtual-dtor', '-Wno-invalid-offsetof', # GCC <4.6 is old-school strict about what is POD. @@ -341,6 +341,13 @@ }, ], + [ 'skia_os == "nacl"', { + # NaCl compiler is GCC 4.4, which is too old to understand 'c++11', so call it '0x'. + # NaCl's newlib needs gnu++ mode to see snprintf, vsnprintf, etc in C++11 mode. + 'cflags_cc!': [ '-std=c++11' ], + 'cflags_cc' : [ '-std=gnu++0x' ], + }], + ['skia_android_framework', { 'includes' : [ 'skia_for_android_framework_defines.gypi', @@ -479,8 +486,6 @@ }], [ 'skia_clang_build', { 'cflags_cc': [ - # Build in C++11 mode to make sure we'll have an easy time switching. - '-std=c++11', '-Wno-unknown-warning-option', # Allows unknown warnings. '-Wno-deprecated', # From Qt, via debugger (older Clang). '-Wno-deprecated-register', # From Qt, via debugger (newer Clang). @@ -586,6 +591,7 @@ 'TARGETED_DEVICE_FAMILY': '1,2', 'GCC_WARN_ABOUT_INVALID_OFFSETOF_MACRO': 'NO', # -Wno-invalid-offsetof 'OTHER_CPLUSPLUSFLAGS': [ + '-std=c++0x', '-fvisibility=hidden', '-fvisibility-inlines-hidden', ], |