diff options
| author |  mtklein <mtklein@chromium.org> | 2014-09-08 12:42:23 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2014-09-08 12:42:23 -0700 |
| commit | e2d4eb70724475035d6148ba279f9cb1c2433564 (patch) | |
| tree | e209e70ca8534cf641b1590ace19acf85cee37f3 /gyp | |
| parent | 655ad128d054005ce5e55cc6f0b75a4dec07ccce (diff) | |
Hash .pngs instead of SkBitmaps.
This has the nice property of being able to double-check hashes after the fact.
mtklein@mtklein ~/skia (hash-png)> md5sum bad/8888/3x3bitmaprect.png
deede70ab2f34067d461fb4a93332d4c bad/8888/3x3bitmaprect.png
mtklein@mtklein ~/skia (hash-png)> grep 3x3bitmaprect_8888 bad/dm.json
"3x3bitmaprect_8888" : "deede70ab2f34067d461fb4a93332d4c",
I have checked that no two premultiplied colors map to the same unpremultiplied
color (math nerds: unpremultiplication is injective), so a change in
premultiplied SkBitmap will always imply a change in the encoded
unpremultiplied .png. This means, it's safe to hash .pngs; we won't miss
subtle changes.
BUG=skia:
R=jcgregorio@google.com, stephana@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/549203003
Diffstat (limited to 'gyp')
| -rw-r--r-- | gyp/tests.gypi | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/gyp/tests.gypi b/gyp/tests.gypi index cf78e41f63..15f5d0445b 100644 --- a/gyp/tests.gypi +++ b/gyp/tests.gypi @@ -205,6 +205,7 @@ '../tests/TracingTest.cpp', '../tests/TypefaceTest.cpp', '../tests/UnicodeTest.cpp', + '../tests/UnpremultiplyTest.cpp', '../tests/UtilsTest.cpp', '../tests/WArrayTest.cpp', '../tests/WritePixelsTest.cpp', |