diff options
author | 2014-03-28 18:05:29 +0000 | |
---|---|---|
committer | 2014-03-28 18:05:29 +0000 | |
commit | d643a90ee248d22ec8260512812dee6d463de555 (patch) | |
tree | 3260334e7d03e5f509ff4a5546457f17e4f3d029 /gyp | |
parent | 972f9cd7a063d0544f8c919fd12b9a3adbd12b24 (diff) |
Revert of ARM Skia NEON patches - 35 - First AArch64 support (https://codereview.chromium.org/143423004/)
Reason for revert:
GYP's failing on most (all?) bots.
Original issue's description:
> ARM Skia NEON patches - 35 - First AArch64 support
>
> Aarch64 support
>
> This change contains the necessary modifications to have Skia build and
> run properly on an ARMv8 processor in aarch64 execution state.
>
> Here's a list of the changes:
>
> - add an arm64 target to the build system + SK_CPU_ARM64 flag
>
> - MatrixTest was failing when built in Release mode. Fused MAC
> instructions were generated which made some intermediate results
> more accurate. As the test relies on result comparison, the more
> precise results when compared to others led to a gap bigger than
> what was tolerated. As I don't know if some actual skia code relies
> on results being comparable, I've disabled fused MAC instruction
> with -ffp-contract=off for arm64.
>
> - Modify include/core/SkOnce.h to have barriers work.
>
> - SK_CPU_ARM64 implies SK_ARM_NEON_MODE_ALWAYS.
>
> - use existing Xfermode optimisations with modifications that can be
> removed in the future when toolchains are ready. Also save a few
> instructions is two Xfermodes (will apply to ARM too).
>
> - use existing SkBoxBlur and SkMorphology optimisations.
>
> - use existing SkBlitMask optimisations
>
> - use existing BitmapProcState and Convolution optimisations.
>
> Future changes will include:
>
> - Blitters (only partialy merged upstream)
>
> - SkUtils (there's little value in sending asm optimisations without
> having them benchmarked on real hardware).
>
> Signed-off-by: Kevin PETIT <kevin.petit@arm.com>
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=13980
R=djsollen@google.com, reed@google.com, halcanary@google.com, kevin.petit@arm.com
TBR=djsollen@google.com, halcanary@google.com, kevin.petit@arm.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/216113005
git-svn-id: http://skia.googlecode.com/svn/trunk@13983 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'gyp')
-rw-r--r-- | gyp/common_conditions.gypi | 6 | ||||
-rw-r--r-- | gyp/common_variables.gypi | 2 | ||||
-rw-r--r-- | gyp/opts.gyp | 17 |
3 files changed, 1 insertions, 24 deletions
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi index 777473b9cf..82f63f375b 100644 --- a/gyp/common_conditions.gypi +++ b/gyp/common_conditions.gypi @@ -8,12 +8,6 @@ 'SK_FORCE_DISTANCEFIELD_FONTS=<(skia_force_distancefield_fonts)', ], 'conditions' : [ - [ 'skia_arch_type == "arm64"', { - 'cflags': [ - '-ffp-contract=off', - ], - }], - [ 'skia_os == "win"', { 'defines': [ diff --git a/gyp/common_variables.gypi b/gyp/common_variables.gypi index 0d749f4004..6145d47e01 100644 --- a/gyp/common_variables.gypi +++ b/gyp/common_variables.gypi @@ -72,7 +72,7 @@ }, { 'skia_poppler_enabled%': 0, }], - [ 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "mac"] or skia_arch_type == "arm64"', { + [ 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "mac"]', { 'skia_arch_width%': 64, }, { 'skia_arch_width%': 32, diff --git a/gyp/opts.gyp b/gyp/opts.gyp index 783ea4eb7a..2fd0e95809 100644 --- a/gyp/opts.gyp +++ b/gyp/opts.gyp @@ -122,23 +122,6 @@ '-mno-apcs-frame', ] }], - [ 'skia_arch_type == "arm64"', { - 'sources': [ - '../src/opts/SkBitmapProcState_arm_neon.cpp', - '../src/opts/SkBitmapProcState_matrixProcs_neon.cpp', - '../src/opts/SkBitmapProcState_opts_arm.cpp', - '../src/opts/SkBlitMask_opts_arm.cpp', - '../src/opts/SkBlitMask_opts_arm_neon.cpp', - '../src/opts/SkBlitRow_opts_none.cpp', - '../src/opts/SkBlurImage_opts_arm.cpp', - '../src/opts/SkBlurImage_opts_neon.cpp', - '../src/opts/SkMorphology_opts_arm.cpp', - '../src/opts/SkMorphology_opts_neon.cpp', - '../src/opts/SkUtils_opts_none.cpp', - '../src/opts/SkXfermode_opts_arm.cpp', - '../src/opts/SkXfermode_opts_arm_neon.cpp', - ], - }], ], }, # For the same lame reasons as what is done for skia_opts, we have to |