diff options
| author |  rmistry <rmistry@google.com> | 2014-06-23 06:59:15 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2014-06-23 06:59:15 -0700 |
| commit | c4b84aef1adeb68bc853f35abb85b79fa1fcaac6 (patch) | |
| tree | 54b63d339f397610f8bde7efb17c10ce3acbbbe5 /gyp | |
| parent | 05ead8afe5e4db21f9004334ac339bdad48d5057 (diff) | |
Revert of Revert of Fix SkPaint::measureText for stroked hairline text (https://codereview.chromium.org/354433002/)
Reason for revert:
Rebaseline CL is ready to be submitted
Original issue's description:
> Revert of Fix SkPaint::measureText for stroked hairline text (https://codereview.chromium.org/335603003/)
>
> Reason for revert:
> Caused many shadertext GM failures
>
> Original issue's description:
> > Fix SkPaint::measureText for stroked hairline text
> >
> > SkPaint::measureText and text drawing used different criteria for
> > determining whether text should be drawn as paths or not.
> >
> > Adds tests glyph_pos_(h/n)_(s/f/b) to test the text rendering and the glyph
> > positioning in the rendering. Mainly added in order to define what is the
> > expected text rendering when hairline stroke is used with various transform
> > options.
> >
> > The testcase also tries to note or highlight the fact that SkPaint::measureText
> > is not expected to produce intuitively matching results when compared to a
> > rendering, if the rendering is done so that the device ends up having a device
> > transform.
> >
> > This fixes the glyph_pos_h_s (hairline, stroked) test-case.
> >
> > Ignore shadertext2_pdf-poppler.png gm on
> > Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug temporarily, as that fails.
> >
> > Committed: https://skia.googlesource.com/skia/+/196af738027c5e18c3eb792dbcaf90ef27821793
>
> TBR=jvanverth@google.com,reed@google.com,kkinnunen@nvidia.com
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/abc9bb55ddfeb4b1a7acc335a34841fddcd22d27
R=jvanverth@google.com, reed@google.com, kkinnunen@nvidia.com
TBR=jvanverth@google.com, kkinnunen@nvidia.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/349153005
Diffstat (limited to 'gyp')
| -rw-r--r-- | gyp/gmslides.gypi | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/gyp/gmslides.gypi b/gyp/gmslides.gypi index 18e589b3f4..694ec72f40 100644 --- a/gyp/gmslides.gypi +++ b/gyp/gmslides.gypi @@ -83,6 +83,7 @@ '../gm/gammatext.cpp', '../gm/getpostextpath.cpp', '../gm/giantbitmap.cpp', + '../gm/glyph_pos.cpp', '../gm/gradients.cpp', '../gm/gradients_2pt_conical.cpp', '../gm/gradients_no_texture.cpp', |