diff options
| author |  mtklein <mtklein@google.com> | 2014-11-21 14:42:35 -0800 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2014-11-21 14:42:35 -0800 |
| commit | c0591ca026144230f08b0c8d2c9b8f47e039fca4 (patch) | |
| tree | b6f9ee04463f5bd0599354b4809bbe24660fea46 /gyp | |
| parent | 77d77f446d1685cd21465627a747341c3c3665e4 (diff) | |
Revert of Add -ftrapv to debug builds. (patchset #1 id:1 of https://codereview.chromium.org/702893003/)
Reason for revert:
Not clean yet.
Original issue's description:
> Add -ftrapv to debug builds.
>
> This adds instrumentation to check that signed integers never under- or
> overflow, which is undefined behavior.
>
> BUG=skia:3096
>
> Committed: https://skia.googlesource.com/skia/+/ebacb6127a952910f43a59460af43427d93df46c
TBR=bungeman@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:3096
Review URL: https://codereview.chromium.org/751713002
Diffstat (limited to 'gyp')
| -rw-r--r-- | gyp/common_conditions.gypi | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi index 16841512c1..059806f5e3 100644 --- a/gyp/common_conditions.gypi +++ b/gyp/common_conditions.gypi @@ -414,7 +414,6 @@ 'ldflags': ['--coverage'], }, 'Debug': { - 'cflags': ['-ftrapv'], # Crash on signed integer over/underflow. }, 'Release': { 'cflags': [ @@ -595,7 +594,7 @@ ], 'configurations': { 'Debug': { - 'cflags': ['-g', '-ftrapv'] + 'cflags': ['-g'] }, 'Release': { 'cflags': ['-O2'], |