diff options
| author |  mtklein <mtklein@google.com> | 2014-09-17 06:58:39 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2014-09-17 06:58:39 -0700 |
| commit | 963504bd0a8ced7e1177ae136da03a9cc343d886 (patch) | |
| tree | 60549931ef677b5ae55a7f874b03d56f3c19098a /gyp | |
| parent | b0a35f7c5d2c4bfeb601e3ac43f412d202a25292 (diff) | |
Revert of nanobench: lazily decode bitmaps from SKPs (patchset #1 id:1 of https://codereview.chromium.org/572933006/)
Reason for revert:
skia:2944
Original issue's description:
> nanobench: lazily decode bitmaps from SKPs
>
> This makes it considerably cheaper to run SKP recording benchmarks, without
> affecting their measurements and without really affecting SKP playback
> benchmarks at all.
>
> On my machine, running out/Release/nanobench --match skp --config nondrendering
> drops in run time from 6.7s to 2.5s, and the peak RAM usage drops from 129M to 50M.
>
> I'm strongly considering making this lazy decoding the default.
>
> BUG=skia:2944
>
> Committed: https://skia.googlesource.com/skia/+/d664c21a38de98d8db210c46f7a8c4187f1534da
R=robertphillips@google.com, mtklein@chromium.org
TBR=mtklein@chromium.org, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2944
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/554583004
Diffstat (limited to 'gyp')
| -rw-r--r-- | gyp/bench.gyp | 3 | ||||
| -rw-r--r-- | gyp/iOSShell.gyp | 1 |
2 files changed, 1 insertions, 3 deletions
diff --git a/gyp/bench.gyp b/gyp/bench.gyp index 08f173c8b2..26849d511a 100644 --- a/gyp/bench.gyp +++ b/gyp/bench.gyp @@ -9,12 +9,11 @@ 'target_name': 'nanobench', 'type': 'executable', 'sources': [ + '../gm/gm.cpp', '../bench/GMBench.cpp', '../bench/RecordingBench.cpp', '../bench/SKPBench.cpp', '../bench/nanobench.cpp', - '../gm/gm.cpp', - '../tools/LazyDecodeBitmap.cpp', ], 'includes': [ 'bench.gypi', diff --git a/gyp/iOSShell.gyp b/gyp/iOSShell.gyp index 20c4994be1..ac2ed30303 100644 --- a/gyp/iOSShell.gyp +++ b/gyp/iOSShell.gyp @@ -23,7 +23,6 @@ '../bench/SKPBench.cpp', '../bench/nanobench.cpp', '../tests/skia_test.cpp', - '../tools/LazyDecodeBitmap.cpp', '../tools/iOSShell.cpp', '../src/views/mac/SkEventNotifier.mm', '../experimental/iOSSampleApp/SkiOSSampleApp-Base.xcconfig', |