aboutsummaryrefslogtreecommitdiffhomepage
path: root/gyp
diff options
context:
space:
mode:
authorGravatar mtklein <mtklein@chromium.org>2014-08-20 07:38:46 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2014-08-20 07:38:46 -0700
commit753b870c62bd22cee3d9a15efc634822724084ac (patch)
treeeac4b0e94cb975daa0ae5c5f49188aab797f58ab /gyp
parentb88813683cb1242ee5d0b6d8f5deb50b39e81e7f (diff)
Define NDEBUG instead of SK_DEBUG/SK_RELEASE.
This makes our builds more like Chrome's, and will make our builds fail if we accidentally use if SK_DEBUG instead of ifdef SK_DEBUG. BUG=skia: R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/481513004
Diffstat (limited to 'gyp')
-rw-r--r--gyp/common.gypi17
1 files changed, 3 insertions, 14 deletions
diff --git a/gyp/common.gypi b/gyp/common.gypi
index 14a541912b..2d3fddd47d 100644
--- a/gyp/common.gypi
+++ b/gyp/common.gypi
@@ -92,22 +92,11 @@
# one makefile and allow someone to add SK_DEBUG etc for their own
# debugging purposes.
'configurations': {
- 'Debug': {
- 'defines': [
- 'SK_DEBUG',
- 'SK_DEVELOPER=1',
- ],
- },
- 'Release': {
- 'defines': [
- 'SK_RELEASE',
- ],
- },
+ 'Debug': { 'defines': [ 'SK_DEVELOPER=1' ] },
+ 'Release': { 'defines': [ 'NDEBUG' ] },
'Release_Developer': {
'inherit_from': ['Release'],
- 'defines': [
- 'SK_DEVELOPER=1',
- ],
+ 'defines': [ 'SK_DEVELOPER=1' ],
},
},
}],