diff options
| author |  scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-12-02 20:18:09 +0000 |
|---|---|---|
| committer | scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-12-02 20:18:09 +0000 |
| commit | 248647cebb3724fd2ce1d41745afb786516af4f8 (patch) | |
| tree | ade53aade566adfa77c86ba7787e32efb1811403 /gyp | |
| parent | 24339aa2113cf0a018109318e9900902ee5b0023 (diff) | |
Restructuring of PdfViewer code.
The only change in behavior is that SkPdfAllocator on SkPdfContext is
no longer allocated on the heap.
In general, I have just moved code.
SkPdfContext:
Inherit from SkNoncopyable.
Make SkPdfContext directly own fTmpPageAllocator. fTmpPageAllocator is
created when SkPdfContext is, and destroyed at the same time as well,
so there is no reason for the extra allocation.
Add the function parseStream. This eliminates code duplication, and
allows making fTmpPageAllocator private.
Move PdfMainLooper into the implementation file, since it is now only
used by parseStream.
Move SkTDictWithDefaultConstructor and render stats info here, in
support of PdfMainLooper.
SkPdfTokenLooper:
Rename PdfTokenLooper to SkPdfTokenLooper.
Move readToken here, unchanged.
Remove tokenizer(), which is unused.
SkPdfNativeDoc:
Remove tokenizerOfPage and tokenizerOfBuffer, which are unused.
SkPdfOps:
Move gPdfOps and PdfOperatorRenderer into a header file (hidden for
now), so they can be accessed by both SkPdfRenderer.cpp and
SkPdfContext.cpp.
SkPdfRenderer:
Harvest things into other files:
PdfMainLooper (and the code that calls it) -> SkPdfContext.
readToken -> SkPdfTokenLooper.
R=mtklein@google.com
Review URL: https://codereview.chromium.org/79933003
git-svn-id: http://skia.googlecode.com/svn/trunk@12435 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'gyp')
| -rw-r--r-- | gyp/pdfviewer_lib.gyp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/gyp/pdfviewer_lib.gyp b/gyp/pdfviewer_lib.gyp index 37b12855cb..405d02cc85 100644 --- a/gyp/pdfviewer_lib.gyp +++ b/gyp/pdfviewer_lib.gyp @@ -18,6 +18,7 @@ '../experimental/PdfViewer/src/SkPdfContext.cpp', '../experimental/PdfViewer/src/SkPdfRenderer.cpp', '../experimental/PdfViewer/src/SkTDStackNester.h', + '../experimental/PdfViewer/src/SkPdfTokenLooper.cpp', '../experimental/PdfViewer/SkPdfGraphicsState.cpp', '../experimental/PdfViewer/SkPdfFont.cpp', |