diff options
author | scroggo <scroggo@google.com> | 2016-02-02 11:56:33 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-02-02 11:56:33 -0800 |
commit | 1497f9f2641b539f0bc45b4f1496ceab7d56b18c (patch) | |
tree | fe426c1c965b05d29eea59e5ee2988286cae98cd /gyp | |
parent | 136f517627556f9f831f92bc3e9e51c1ab9241d3 (diff) |
Update SK_IMAGE_VERSION to test RAW
Bump SK_IMAGE_VERSION to test the images in v2 in GoogleStorage, which
includes the images from v1 plus test images for SkRawCodec.
Only define skia_decodes_raw on platforms that support it, rather than
defining it always and checking additional conditions to determine
whether to support raw. Further, define it and SK_CODEC_DECODES_RAW
for all targets, so we can use the compile flag in other targets.
In DM, exclude the raw extensions if SK_CODEC_DECODES_RAW is not defined.
Blacklist raw extensions on NexusPlayer, which was running out of memory
when running them.
BUG=skia:4829
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1612113002
Review URL: https://codereview.chromium.org/1612113002
Diffstat (limited to 'gyp')
-rw-r--r-- | gyp/codec.gyp | 11 | ||||
-rw-r--r-- | gyp/common_conditions.gypi | 5 | ||||
-rw-r--r-- | gyp/common_variables.gypi | 14 |
3 files changed, 17 insertions, 13 deletions
diff --git a/gyp/codec.gyp b/gyp/codec.gyp index 596270a570..2043b35567 100644 --- a/gyp/codec.gyp +++ b/gyp/codec.gyp @@ -68,8 +68,7 @@ 'TURBO_HAS_SKIP', ], 'conditions': [ - # FIXME: fix the support for ChromeOS [DNG SDK issue with clock_gettime()]. - ['skia_codec_decodes_raw and skia_os != "chromeos"', { + ['skia_codec_decodes_raw', { 'dependencies': [ 'raw_codec', ], @@ -77,7 +76,7 @@ ], }, { # RAW codec needs exceptions. Due to that, it is a separate target. Its usage can be - # controlled by SK_CODEC_DECODES_RAW flag. + # controlled by skia_codec_decodes_raw flag. 'target_name': 'raw_codec', 'product_name': 'raw_codec', 'type': 'static_library', @@ -111,13 +110,7 @@ 'include_dirs': [ '../include/codec', ], - 'defines': [ - 'SK_CODEC_DECODES_RAW', - ], }, - 'defines': [ - 'SK_CODEC_DECODES_RAW', - ], 'conditions': [ ['skia_arch_type == "x86" or skia_arch_type == "arm"', { 'defines': [ diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi index c7b19de8da..11f98bd28d 100644 --- a/gyp/common_conditions.gypi +++ b/gyp/common_conditions.gypi @@ -12,6 +12,11 @@ 'SK_FORCE_DISTANCE_FIELD_TEXT=<(skia_force_distance_field_text)', ], 'conditions' : [ + [ 'skia_codec_decodes_raw', { + 'defines': [ + 'SK_CODEC_DECODES_RAW', + ], + }], ['skia_pic', { 'cflags': [ '-fPIC', diff --git a/gyp/common_variables.gypi b/gyp/common_variables.gypi index abbe729da1..17c5364afc 100644 --- a/gyp/common_variables.gypi +++ b/gyp/common_variables.gypi @@ -38,10 +38,6 @@ 'variables': { # level 1 'angle_path%': '../', - # RAW codec needs exceptions. Due to that, it is a separate target. Its usage can be controlled - # by this variable. - 'skia_codec_decodes_raw%': 1, - 'variables': { # level 2 # Variables needed by conditions list within the level-2 variables dict. @@ -62,6 +58,14 @@ }, { 'skia_arch_type%': 'x86', }], + # RAW codec needs exceptions. Due to that, it is a separate target. Its usage can be + # controlled by skia_codec_decodes_raw. + ['skia_os == "chromeos"', { + # FIXME: fix the support for ChromeOS [DNG SDK issue with clock_gettime()]. + 'skia_codec_decodes_raw%' : 0, + }, { + 'skia_codec_decodes_raw%' : 1, + }], ], 'arm_version%': 0, 'arm_neon%': 0, @@ -72,6 +76,7 @@ # so that siblings of the level-2 'variables' dict can see them. # (skia_os will depend on skia_android_framework.) 'skia_android_framework%': '<(skia_android_framework)', + 'skia_codec_decodes_raw%': '<(skia_codec_decodes_raw)', 'skia_arch_type%': '<(skia_arch_type)', 'arm_version%': '<(arm_version)', 'arm_neon%': '<(arm_neon)', @@ -214,6 +219,7 @@ 'skia_gpu_extra_tests_path%': '<(skia_gpu_extra_tests_path)', 'skia_stroke_path_rendering%': '<(skia_stroke_path_rendering)', 'skia_android_framework%': '<(skia_android_framework)', + 'skia_codec_decodes_raw%': '<(skia_codec_decodes_raw)', 'skia_use_android_framework_defines%': '<(skia_use_android_framework_defines)', 'skia_use_system_json%': '<(skia_use_system_json)', 'skia_android_path_rendering%': '<(skia_android_path_rendering)', |