aboutsummaryrefslogtreecommitdiffhomepage
path: root/gyp/svg.gyp
diff options
context:
space:
mode:
authorGravatar jbroman <jbroman@chromium.org>2016-03-17 12:24:23 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2016-03-17 12:24:23 -0700
commit0e3129d734212089f872f0e7de8f2537861a3f89 (patch)
treea5c9e45f0166af306abd93da69bee65402501da7 /gyp/svg.gyp
parentc9a99872274ab63f2130caeccc75a2f52b8677a3 (diff)
Fix pointer aliasing bug in SkImageFilter::computeFastBounds.
Since src and dst are explicitly allowed to alias (according to a comment in SkPaint.h), it is problematic to have the first input filter mutate dst, since we still need access to the previous value to provide to the other input filters. To resolve this, SkImageFilter::computeFastBounds makes a copy of src on the stack, and passes that to its inputs instead. Also add a unit test that would have detected the issue. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1800263002 Review URL: https://codereview.chromium.org/1800263002
Diffstat (limited to 'gyp/svg.gyp')
0 files changed, 0 insertions, 0 deletions