aboutsummaryrefslogtreecommitdiffhomepage
path: root/gyp/pathops_unittest.gypi
diff options
context:
space:
mode:
authorGravatar scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81>2013-11-20 21:40:57 +0000
committerGravatar scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81>2013-11-20 21:40:57 +0000
commit7d8013f3064cd202f5a2344a1ab1860fd7511bb3 (patch)
tree5f87ee1bb6a82681daa373b351dbbf7e896888c1 /gyp/pathops_unittest.gypi
parent178acd25b0053908ffcdf1b07a9f93d797408b13 (diff)
Changes to SkTDStackNester.
SkTDStackNester is a class used by PdfViewer to assist in saving and restoring the PDF state. Clean up and test this class. Add some documentation. Add FIXME's where I have questions to resolve. Fix a bug where fNestingLevel was not initialized. Remove a commented out line of code copied over from SkTDStack. Rename SkTDStackNester::nests() to nestingLevel() and make it const. Remove unnecessary predeclaration and friend declaration. Remove index() (both const and non-const versions). They were unused, return something that may not be expected (index from the top, rather than from the bottom), and don't work to get any elements in earlier Recs once the first one is full. Report a warning if the nesting level goes above the maximum level, or if we attempt to bring it below zero. Prevent fNestingLevel from dropping below zero. Add kUnusedObject_SkPdfIssue, and use it where appropriate. Depends on https://codereview.chromium.org/64093009/ R=mtklein@google.com Review URL: https://codereview.chromium.org/68843006 git-svn-id: http://skia.googlecode.com/svn/trunk@12328 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'gyp/pathops_unittest.gypi')
0 files changed, 0 insertions, 0 deletions