aboutsummaryrefslogtreecommitdiffhomepage
path: root/gn
diff options
context:
space:
mode:
authorGravatar Mike Klein <mtklein@google.com>2018-04-24 12:32:00 +0000
committerGravatar Mike Klein <mtklein@google.com>2018-04-24 12:37:33 +0000
commitdabf06c0a86c49128b8b70ede1f4ed4356e2c9ef (patch)
tree859824eb69d55b5c08a32c21c6a3893d15f3280d /gn
parentaf88ec37124846a0168a4ab061bf10cc6030c2d6 (diff)
disable skcms on Android framework builds
We need to update BitmapRGBAF16Test.testGetPixel in CTS. We're getting off-by-a-bit errors when enabling skcms. I think we allow a per-byte tolerance of 1 in each of red,green,blue? I'm not convinced the values in the test or the new ones are any more correct than the others. Change-Id: I5196f9315aa8187239eabd58e003d4cb6b603e39 Reviewed-on: https://skia-review.googlesource.com/123246 Reviewed-by: Mike Klein <mtklein@google.com>
Diffstat (limited to 'gn')
-rw-r--r--gn/gn_to_bp.py2
1 files changed, 2 insertions, 0 deletions
diff --git a/gn/gn_to_bp.py b/gn/gn_to_bp.py
index 839b540e95..1e73a97433 100644
--- a/gn/gn_to_bp.py
+++ b/gn/gn_to_bp.py
@@ -236,6 +236,8 @@ defines = [str(d) for d in js['targets']['//:skia']['defines']]
# We need to add skcms.c, which lives in third_party
srcs.add("third_party/skcms/skcms.c")
local_includes.add("third_party/skcms")
+# TODO: re-enable after relaxing CTS tests
+defines.remove('SK_USE_SKCMS')
dm_srcs = strip_slashes(js['targets']['//:dm']['sources'])
dm_includes = strip_slashes(js['targets']['//:dm']['include_dirs'])