diff options
| author |  Florin Malita <fmalita@chromium.org> | 2018-01-03 16:17:29 -0500 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-01-04 00:59:20 +0000 |
| commit | c75e2401a82640c35b0b5f80a5684d0892904530 (patch) | |
| tree | 0742a71071c9b92399a1182ec20ebfc69f8918f9 /gn | |
| parent | 5a59c26193272825e814b50f7d9856c1b122531f (diff) | |
[sksg] Refine invalidation logic
We need to discriminate between nodes whose bounds updates contribute to the dirty
region, and nodes whose bounds changes do not.
E.g. animated shape in a group: the animated shape node bounds should yield damage,
but the ancestor group bounds should not.
To accomplish this, we refine the invalidation state:
1) self invalidation == the node itself was invalidated, and its bounds updates
yield damage.
2) descendant invalidation == the node has some (self-)invalidated descendant,
but its own bounds are not contributing damage.
Also:
* hoist the bounding box invalidation logic into the base class (Node::revalidate)
and update to respect the states described above.
* remove (now-redundant) GeometryNode bbox logic.
* update revalidation methods to return the node bbox instead of void
TBR=
Change-Id: I8023d1793fb501c945a53f2dc2d2983e5b620ade
Reviewed-on: https://skia-review.googlesource.com/90581
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Diffstat (limited to 'gn')
| -rw-r--r-- | gn/tests.gni | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/gn/tests.gni b/gn/tests.gni index 23acda9fd8..a4054b8c01 100644 --- a/gn/tests.gni +++ b/gn/tests.gni @@ -203,6 +203,7 @@ tests_sources = [ "$_tests/ScaleToSidesTest.cpp", "$_tests/SerializationTest.cpp", "$_tests/SerialProcsTest.cpp", + "$_tests/SGTest.cpp", "$_tests/ShaderOpacityTest.cpp", "$_tests/ShaderTest.cpp", "$_tests/ShadowTest.cpp", |