diff options
| author |  Mike Klein <mtklein@chromium.org> | 2018-05-31 13:16:59 -0400 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-06-01 20:15:46 +0000 |
| commit | 804d0f28ba6de89b7e671c0e9192e16b7494944d (patch) | |
| tree | 6dab092fe9ed6a138f95e3cc157a933d03b625ae /gn | |
| parent | 11203af095573b91dcf23398d8557d2963f802a1 (diff) | |
turn on pointer-overflow on ASAN/UBSAN bots
I know SkRasterPipelineBlitter will add back offsets
to the mask pointer to make these fMaskPtr.pixels safe.
SkImageInfo wasn't making out-of-bounds pointers, but was moving
between two in-bounds pointers by subtracting large (negative)
size_t. Switching to explicit negate and add quiets this down.
Bug: chromium:836282
Change-Id: Ia65e380ec41dbfedce0659106830fbacb1a5cf4a
Reviewed-on: https://skia-review.googlesource.com/131147
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Diffstat (limited to 'gn')
| -rw-r--r-- | gn/BUILD.gn | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gn/BUILD.gn b/gn/BUILD.gn index 9d65118c96..80b7f3f1bc 100644 --- a/gn/BUILD.gn +++ b/gn/BUILD.gn @@ -228,7 +228,7 @@ config("default") { fyi_sanitizers = fyi_sanitize if (sanitize == "ASAN" || sanitize == "UBSAN") { # ASAN implicitly runs all UBSAN checks also. - sanitizers = "bool,float-cast-overflow,integer-divide-by-zero,nonnull-attribute,null,return,returns-nonnull-attribute,shift,signed-integer-overflow,unreachable,vla-bound" + sanitizers = "bool,float-cast-overflow,integer-divide-by-zero,nonnull-attribute,null,pointer-overflow,return,returns-nonnull-attribute,shift,signed-integer-overflow,unreachable,vla-bound" if (fyi_sanitize == "" && !is_android) { fyi_sanitizers = "float-divide-by-zero" |