diff options
| author |  Mike Klein <mtklein@chromium.org> | 2016-12-20 17:34:29 -0500 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2016-12-21 03:55:00 +0000 |
| commit | 40a82bd0f48d04680fbe7af063a4f2e3eae122e6 (patch) | |
| tree | 9f8fb95c44dc19c24c48d0f5fed4e8173f771db9 /gn | |
| parent | 6d2f73c364d0d823f14d1ddebc88e0bcbc8f0634 (diff) | |
remove MIPS DSP optimizations
There are only a couple of these, primarily focused on index8 srcs and 565 dsts. The burden's starting to outweigh the benefit. No one on the team knows MIPS assembly.
If we're going to try this again, I'd rather we try some sort of SkNx / compiler-intrinsic based approach, probably targeting MIPS SIMD (MSA), not this older instruction set.
We already ignore these files for 64-bit MIPS. This just closes the loop on 32-bit MIPS.
CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD,Build-Ubuntu-Clang-mips64el-Debug-Android,Build-Ubuntu-Clang-mips64el-Release-Android,Build-Ubuntu-Clang-mipsel-Debug-Android,Build-Ubuntu-Clang-mipsel-Release-Android
BUG=skia:6065
Change-Id: Iecac15b56f59625b2e743ea36e7791b90bb0b422
Reviewed-on: https://skia-review.googlesource.com/6353
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Diffstat (limited to 'gn')
| -rw-r--r-- | gn/gn_to_bp.py | 7 | ||||
| -rw-r--r-- | gn/opts.gni | 6 | ||||
| -rw-r--r-- | gn/shared_sources.gni | 2 |
3 files changed, 4 insertions, 11 deletions
diff --git a/gn/gn_to_bp.py b/gn/gn_to_bp.py index 4ba5db8b18..754db3653d 100644 --- a/gn/gn_to_bp.py +++ b/gn/gn_to_bp.py @@ -61,13 +61,13 @@ cc_library { mips: { srcs: [ - $mips_srcs + $none_srcs ], }, mips64: { srcs: [ - $mips64_srcs + $none_srcs ], }, @@ -199,8 +199,7 @@ with open('Android.bp', 'w') as f: 'arm_neon_srcs': bpfmt(20, scrub(defs['neon'])), 'arm64_srcs': bpfmt(16, scrub(defs['arm64'] + defs['crc32'])), - 'mips_srcs': bpfmt(16, scrub(defs['mips_dsp'])), - 'mips64_srcs': bpfmt(16, scrub(defs['none'])), + 'none_srcs': bpfmt(16, scrub(defs['none'])), 'x86_srcs': bpfmt(16, scrub(defs['sse2'] + defs['ssse3'] + defs['sse41'] + diff --git a/gn/opts.gni b/gn/opts.gni index 02a95cbad5..34481db3b6 100644 --- a/gn/opts.gni +++ b/gn/opts.gni @@ -37,12 +37,6 @@ arm64 = [ crc32 = [ "$_src/opts/SkOpts_crc32.cpp" ] -mips_dsp = [ - "$_src/opts/SkBitmapProcState_opts_mips_dsp.cpp", - "$_src/opts/SkBlitMask_opts_none.cpp", - "$_src/opts/SkBlitRow_opts_mips_dsp.cpp", -] - sse2 = [ "$_src/opts/SkBitmapProcState_opts_SSE2.cpp", "$_src/opts/SkBlitRow_opts_SSE2.cpp", diff --git a/gn/shared_sources.gni b/gn/shared_sources.gni index 36a7dfcd9c..6df999921a 100644 --- a/gn/shared_sources.gni +++ b/gn/shared_sources.gni @@ -18,7 +18,7 @@ skia_opts = { neon_sources = neon arm64_sources = arm64 crc32_sources = crc32 - mips_dsp_sources = mips_dsp + mips_dsp_sources = none # Chrome's src/skia/BUILD.gn uses this. sse2_sources = sse2 ssse3_sources = ssse3 sse41_sources = sse41 |