Move undefined-func-template to wont-fix warnings.

The warning looks to helpfully pre-warn about possible link failures, but it's warning exclusively in places where we're doing things right.

The worst that happens ignoring this warning is a missing-symbol linker error.

I've taken the opportunity to batch in a few other de-escalations:
  - Wconditional-uninitialized is done better by MSAN
  - It'll take some work to dig Wformat-literal out of our shader compiler, but nothing looks unsafe
  - Most of Wshift-sign-overflow is 0xff << 24.  Don't want to ban that.
  - Wdeprecated is mostly warning about features C++11 technically deprecated that might be removed in later releases.  Punt!
  - Wcovered-switch-default is pretty much the opposite of what we want.
  - Wshadow is triggering too often to fix quickly.  Probably mostly false positives.

BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2620

Change-Id: I20a85a77d2e19ed05a536b23037bd988350f821e
Reviewed-on: https://skia-review.googlesource.com/2620
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>

1 files changed, 8 insertions, 10 deletions

diff --git a/gn/BUILD.gn b/gn/BUILD.gn
index 03b36dbeb9..0ae8eeca0e 100644
--- a/gn/BUILD.gn
+++ b/gn/BUILD.gn
@@ -84,20 +84,12 @@ config("default") {
       ]
 
       # High priority to fix!
-      cflags += [
-        "-Wno-conditional-uninitialized",
-        "-Wno-covered-switch-default",
-        "-Wno-deprecated",
-        "-Wno-format-nonliteral",
-        "-Wno-over-aligned",
-        "-Wno-shadow",
-        "-Wno-shift-sign-overflow",
-        "-Wno-undefined-func-template",
-      ]
+      cflags += [ "-Wno-over-aligned" ]
 
       cflags += [
         "-Wno-cast-align",
         "-Wno-class-varargs",
+        "-Wno-conditional-uninitialized",
         "-Wno-conversion",
         "-Wno-disabled-macro-expansion",
         "-Wno-documentation",
@@ -107,6 +99,7 @@ config("default") {
         "-Wno-extra-semi",
         "-Wno-float-conversion",
         "-Wno-float-equal",
+        "-Wno-format-nonliteral",
         "-Wno-global-constructors",  # TODO: OK outside libskia
         "-Wno-gnu-anonymous-struct",
         "-Wno-gnu-zero-variadic-macro-arguments",
@@ -116,6 +109,8 @@ config("default") {
         "-Wno-newline-eof",
         "-Wno-pedantic",
         "-Wno-reserved-id-macro",
+        "-Wno-shadow",
+        "-Wno-shift-sign-overflow",
         "-Wno-sign-conversion",
         "-Wno-switch-enum",
         "-Wno-undef",
@@ -133,6 +128,8 @@ config("default") {
 
       # We are unlikely to want to fix these.
       cflags += [
+        "-Wno-covered-switch-default",
+        "-Wno-deprecated",
         "-Wno-implicit-fallthrough",
         "-Wno-missing-noreturn",
         "-Wno-old-style-cast",
@@ -141,6 +138,7 @@ config("default") {
       cflags_cc += [
         "-Wno-c++98-compat",
         "-Wno-c++98-compat-pedantic",
+        "-Wno-undefined-func-template",
       ]
     }
   }