diff options
| author |  Robert Phillips <robertphillips@google.com> | 2018-02-21 14:17:08 -0500 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-02-21 19:46:56 +0000 |
| commit | 056c1a821afcfbe606615ad1a7d1b554549d0846 (patch) | |
| tree | 33ed26319e742379d7630065dc1ef165296df35d /gn | |
| parent | 9ce9507a7f66634eeb06fc34aebdfb6c4f1a1d11 (diff) | |
Separate creation time & flush time behavior in GrDrawOpAtlas
This CL clarifies what is going on in the GrDrawOpAtlas and GrAtlasGlyphCache.
For the GrDrawOpAtlas:
At creation time all the allowed pages are created (with their backing GrTextureProxies) but they aren't instantiated.
The GrDrawOpAtlas::instantiate call is called in preFlushCB and allocates any pages known to be needed at the start of flush
GrDrawOpAtlas::addToAtlas is called at flush time and, if a new page is activated, will instantiated it at that time.
During compaction, an unused page will be deInstantiated but its Plots and backing GrTextureProxy will remain alive.
The GrAtlasGlyphCache reflects the changes to the GrDrawOpAtlas
It now carries a GrProxyProvider for when it needs to create an atlas
It passes in a GrResourceProvider* at flush time to allow instantiation.
It does not, yet, allocate that GrDrawOpAtlases it might ever require.
Change-Id: I54909b7a3ba4bec2db5f1218f6a2a3a1636f66d6
Reviewed-on: https://skia-review.googlesource.com/108520
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Diffstat (limited to 'gn')
| -rw-r--r-- | gn/tests.gni | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/gn/tests.gni b/gn/tests.gni index 58b1ff05c6..02293a0b48 100644 --- a/gn/tests.gni +++ b/gn/tests.gni @@ -60,6 +60,7 @@ tests_sources = [ "$_tests/DiscardableMemoryTest.cpp", "$_tests/DrawBitmapRectTest.cpp", "$_tests/DrawFilterTest.cpp", + "$_tests/DrawOpAtlasTest.cpp", "$_tests/DrawPathTest.cpp", "$_tests/DrawTextTest.cpp", "$_tests/DynamicHashTest.cpp", |