diff options
| author |  Mike Klein <mtklein@chromium.org> | 2016-12-12 10:29:38 -0500 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2016-12-12 16:16:44 +0000 |
| commit | f44703a87f532b3f593d91605d66d52c6bbc45c9 (patch) | |
| tree | 32e402bc1d505e7039df79f6f7526726d94d67d6 /gn/gn_to_bp.py | |
| parent | 4958006657dc3d6bbad933217b687e275f1554a3 (diff) | |
Remove dependency on NDK cpufeatures.
Instead of relying on cpu-features.c, just do what it does.
Good reading: http://man7.org/linux/man-pages/man3/getauxval.3.html
While it's nice to use the headers when possible, should either of these headers not be available, we can fall back to doing it all manually:
extern "C" uint32_t getauxval(uint32_t)
static const int AT_HWCAP = 16;
static const int HWCAP_CRC32 = (1<<7);
To keep things simple I've slimmed cpu feature detection down to just the features we actually make use of. This removes all runtime feature detection for ARMv7... we expect NEON to be globally available, and so far we haven't used the other FMA/FP16 bits on ARMv7. ARMv8 feature dection remains the same, CRC32 before, CRC32 after. x86 (cpuid-based detection) and MIPS (nothing) are untouched.
We need to keep //third_party/cpu-features for //third_party/libwebp.
Change-Id: I6c96df9a09ae68c8c0e54c1152aa177ba9bafc83
Reviewed-on: https://skia-review.googlesource.com/5800
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Diffstat (limited to 'gn/gn_to_bp.py')
| -rw-r--r-- | gn/gn_to_bp.py | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/gn/gn_to_bp.py b/gn/gn_to_bp.py index 1791697d37..3e81042ace 100644 --- a/gn/gn_to_bp.py +++ b/gn/gn_to_bp.py @@ -81,7 +81,6 @@ cc_library { "libz", ], static_libs: [ - //"cpufeatures", // TODO: use this for CRC32 detection "libsfntly", "libwebp-decode", "libwebp-encode", @@ -92,7 +91,6 @@ cc_library { # We'll run GN to get the main source lists and include directories for Skia. gn_args = { 'skia_enable_vulkan_debug_layers': 'false', - 'skia_use_cpufeatures': 'false', 'skia_use_system_expat': 'true', 'skia_use_vulkan': 'true', 'target_cpu': '"none"', |