diff options
author | egdaniel <egdaniel@google.com> | 2016-06-17 15:11:45 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-06-17 15:11:46 -0700 |
commit | 802acec1876bb647aaab1bbcfd97748bba54da8f (patch) | |
tree | 0016427a547439bc8403ff92079c635607db869b /gm | |
parent | 992a22d2e9f976f801c5de06c37f013293f11a82 (diff) |
Revert of More removal of SkColorProfileType... (patchset #2 id:20001 of https://codereview.chromium.org/2071393002/ )
Reason for revert:
This was still used in chrome
Original issue's description:
> More removal of SkColorProfileType...
>
> Scrub GMs. Remove the gDefaultProfile thing (it's unused now), along with
> the command line flag that was setting it in DM and nanobench.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2071393002
>
> Committed: https://skia.googlesource.com/skia/+/944876f2745a62a839e49275daf93a0329372e67
TBR=msarett@google.com,reed@google.com,bsalomon@google.com,brianosman@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2074103004
Diffstat (limited to 'gm')
-rw-r--r-- | gm/SkLinearBitmapPipelineGM.cpp | 5 | ||||
-rw-r--r-- | gm/all_bitmap_configs.cpp | 12 | ||||
-rw-r--r-- | gm/color4f.cpp | 9 | ||||
-rw-r--r-- | gm/dftext.cpp | 5 | ||||
-rw-r--r-- | gm/gamma.cpp | 8 | ||||
-rw-r--r-- | gm/surface.cpp | 2 | ||||
-rw-r--r-- | gm/textblobgeometrychange.cpp | 3 | ||||
-rw-r--r-- | gm/textblobmixedsizes.cpp | 6 | ||||
-rw-r--r-- | gm/textblobrandomfont.cpp | 4 | ||||
-rw-r--r-- | gm/xfermodes3.cpp | 2 |
10 files changed, 24 insertions, 32 deletions
diff --git a/gm/SkLinearBitmapPipelineGM.cpp b/gm/SkLinearBitmapPipelineGM.cpp index c78bc74e23..777f825780 100644 --- a/gm/SkLinearBitmapPipelineGM.cpp +++ b/gm/SkLinearBitmapPipelineGM.cpp @@ -55,7 +55,7 @@ static void draw_rect_orig(SkCanvas* canvas, const SkRect& r, SkColor c, const S SkPixmap pmdst; bmdst.peekPixels(&pmdst); - SkImageInfo info = SkImageInfo::MakeN32Premul(ir.width(), ir.height()); + SkImageInfo info = SkImageInfo::MakeN32Premul(ir.width(), ir.height(), kLinear_SkColorProfileType); sk_sp<SkImage> image(SkImage::MakeRasterCopy(SkPixmap(info, pmsrc.addr32(), pmsrc.rowBytes()))); SkPaint paint; @@ -113,6 +113,9 @@ static void draw_rect_fp(SkCanvas* canvas, const SkRect& r, SkColor c, const SkM } uint32_t flags = 0; + //if (kSRGB_SkColorProfileType == profile) { + //flags |= SkXfermode::kDstIsSRGB_PM4fFlag; + //} auto procN = SkXfermode::GetD32Proc(nullptr, flags); SkLinearBitmapPipeline pipeline{ diff --git a/gm/all_bitmap_configs.cpp b/gm/all_bitmap_configs.cpp index b657f4fa7c..7ea17466d9 100644 --- a/gm/all_bitmap_configs.cpp +++ b/gm/all_bitmap_configs.cpp @@ -246,13 +246,13 @@ static uint32_t make_pixel(int x, int y, SkAlphaType alphaType) { static void make_color_test_bitmap_variant( SkColorType colorType, SkAlphaType alphaType, - sk_sp<SkColorSpace> colorSpace, + SkColorProfileType profile, SkBitmap* bm) { SkASSERT(colorType == kRGBA_8888_SkColorType || colorType == kBGRA_8888_SkColorType); SkASSERT(alphaType == kPremul_SkAlphaType || alphaType == kUnpremul_SkAlphaType); bm->allocPixels( - SkImageInfo::Make(SCALE, SCALE, colorType, alphaType, colorSpace)); + SkImageInfo::Make(SCALE, SCALE, colorType, alphaType, profile)); SkPixmap pm; bm->peekPixels(&pm); for (int y = 0; y < bm->height(); y++) { @@ -265,17 +265,13 @@ static void make_color_test_bitmap_variant( DEF_SIMPLE_GM(all_variants_8888, canvas, 4 * SCALE + 30, 2 * SCALE + 10) { sk_tool_utils::draw_checkerboard(canvas, SK_ColorLTGRAY, SK_ColorWHITE, 8); - sk_sp<SkColorSpace> colorSpaces[] { - nullptr, - SkColorSpace::NewNamed(SkColorSpace::kSRGB_Named) - }; - for (auto colorSpace : colorSpaces) { + for (auto profile : {kSRGB_SkColorProfileType, kLinear_SkColorProfileType}) { canvas->save(); for (auto alphaType : {kPremul_SkAlphaType, kUnpremul_SkAlphaType}) { canvas->save(); for (auto colorType : {kRGBA_8888_SkColorType, kBGRA_8888_SkColorType}) { SkBitmap bm; - make_color_test_bitmap_variant(colorType, alphaType, colorSpace, &bm); + make_color_test_bitmap_variant(colorType, alphaType, profile, &bm); canvas->drawBitmap(bm, 0.0f, 0.0f); canvas->translate(SCALE + 10, 0.0f); } diff --git a/gm/color4f.cpp b/gm/color4f.cpp index 5a516a569b..33d837786a 100644 --- a/gm/color4f.cpp +++ b/gm/color4f.cpp @@ -73,13 +73,10 @@ DEF_SIMPLE_GM(color4f, canvas, 1024, 260) { // even if it holds sRGB values. bg.setColor(0xFFFFFFFF); - sk_sp<SkColorSpace> colorSpaces[]{ - nullptr, - SkColorSpace::NewNamed(SkColorSpace::kSRGB_Named) - }; - for (auto colorSpace : colorSpaces) { + SkColorProfileType const profiles[] { kLinear_SkColorProfileType, kSRGB_SkColorProfileType }; + for (auto profile : profiles) { const SkImageInfo info = SkImageInfo::Make(1024, 100, kN32_SkColorType, kPremul_SkAlphaType, - colorSpace); + profile); auto surface(SkSurface::MakeRaster(info)); surface->getCanvas()->drawPaint(bg); draw_into_canvas(surface->getCanvas()); diff --git a/gm/dftext.cpp b/gm/dftext.cpp index 42d650ed2f..05aef4c9d6 100644 --- a/gm/dftext.cpp +++ b/gm/dftext.cpp @@ -48,9 +48,8 @@ protected: // set up offscreen rendering with distance field text #if SK_SUPPORT_GPU GrContext* ctx = inputCanvas->getGrContext(); - SkISize size = onISize(); - SkImageInfo info = SkImageInfo::MakeN32(size.width(), size.height(), kPremul_SkAlphaType, - sk_ref_sp(inputCanvas->imageInfo().colorSpace())); + SkImageInfo info = SkImageInfo::MakeN32Premul(onISize(), + inputCanvas->imageInfo().profileType()); SkSurfaceProps canvasProps(SkSurfaceProps::kLegacyFontHost_InitType); uint32_t gammaCorrect = inputCanvas->getProps(&canvasProps) ? canvasProps.flags() & SkSurfaceProps::kGammaCorrect_Flag : 0; diff --git a/gm/gamma.cpp b/gm/gamma.cpp index eb4c7607fe..c9fa28be10 100644 --- a/gm/gamma.cpp +++ b/gm/gamma.cpp @@ -18,7 +18,6 @@ DEF_SIMPLE_GM(gamma, canvas, 560, 200) { const SkScalar tx = sz + 5.0f; const SkRect r = SkRect::MakeXYWH(0, 0, sz, sz); SkShader::TileMode rpt = SkShader::kRepeat_TileMode; - auto srgbColorSpace = SkColorSpace::NewNamed(SkColorSpace::kSRGB_Named); SkBitmap ditherBmp; ditherBmp.allocN32Pixels(2, 2); @@ -27,20 +26,21 @@ DEF_SIMPLE_GM(gamma, canvas, 560, 200) { pixels[1] = pixels[2] = SkPackARGB32(0xFF, 0, 0, 0); SkBitmap linearGreyBmp; - SkImageInfo linearGreyInfo = SkImageInfo::MakeN32(szInt, szInt, kOpaque_SkAlphaType, nullptr); + SkImageInfo linearGreyInfo = SkImageInfo::MakeN32(szInt, szInt, kOpaque_SkAlphaType, + kLinear_SkColorProfileType); linearGreyBmp.allocPixels(linearGreyInfo); linearGreyBmp.eraseARGB(0xFF, 0x7F, 0x7F, 0x7F); SkBitmap srgbGreyBmp; SkImageInfo srgbGreyInfo = SkImageInfo::MakeN32(szInt, szInt, kOpaque_SkAlphaType, - srgbColorSpace); + kSRGB_SkColorProfileType); srgbGreyBmp.allocPixels(srgbGreyInfo); // 0xBC = 255 * linear_to_srgb(0.5f) srgbGreyBmp.eraseARGB(0xFF, 0xBC, 0xBC, 0xBC); SkBitmap mipmapBmp; SkImageInfo mipmapInfo = SkImageInfo::Make(2, 2, kN32_SkColorType, kOpaque_SkAlphaType, - srgbColorSpace); + SkColorSpace::NewNamed(SkColorSpace::kSRGB_Named)); mipmapBmp.allocPixels(mipmapInfo); SkPMColor* mipmapPixels = reinterpret_cast<SkPMColor*>(mipmapBmp.getPixels()); unsigned s25 = 0x89; // 255 * linear_to_srgb(0.25f) diff --git a/gm/surface.cpp b/gm/surface.cpp index bae77c5594..15d362efd5 100644 --- a/gm/surface.cpp +++ b/gm/surface.cpp @@ -78,7 +78,7 @@ protected: // must be opaque to have a hope of testing LCD text const SkImageInfo info = SkImageInfo::MakeN32(W, H, kOpaque_SkAlphaType, - sk_ref_sp(canvas->imageInfo().colorSpace())); + canvas->imageInfo().profileType()); SkSurfaceProps canvasProps(SkSurfaceProps::kLegacyFontHost_InitType); bool gammaCorrect = canvas->getProps(&canvasProps) && canvasProps.isGammaCorrect(); diff --git a/gm/textblobgeometrychange.cpp b/gm/textblobgeometrychange.cpp index a241c5c7ba..87c432f5b7 100644 --- a/gm/textblobgeometrychange.cpp +++ b/gm/textblobgeometrychange.cpp @@ -42,8 +42,7 @@ protected: SkAutoTUnref<const SkTextBlob> blob(builder.build()); - SkImageInfo info = SkImageInfo::MakeN32(200, 200, kPremul_SkAlphaType, - sk_ref_sp(canvas->imageInfo().colorSpace())); + SkImageInfo info = SkImageInfo::MakeN32Premul(200, 200, canvas->imageInfo().profileType()); SkSurfaceProps canvasProps(SkSurfaceProps::kLegacyFontHost_InitType); uint32_t gammaCorrect = canvas->getProps(&canvasProps) ? canvasProps.flags() & SkSurfaceProps::kGammaCorrect_Flag : 0; diff --git a/gm/textblobmixedsizes.cpp b/gm/textblobmixedsizes.cpp index 8fdf558206..8f5dc85e48 100644 --- a/gm/textblobmixedsizes.cpp +++ b/gm/textblobmixedsizes.cpp @@ -102,10 +102,8 @@ protected: #if SK_SUPPORT_GPU // Create a new Canvas to enable DFT GrContext* ctx = inputCanvas->getGrContext(); - SkISize size = onISize(); - sk_sp<SkColorSpace> colorSpace = sk_ref_sp(inputCanvas->imageInfo().colorSpace()); - SkImageInfo info = SkImageInfo::MakeN32(size.width(), size.height(), - kPremul_SkAlphaType, colorSpace); + SkImageInfo info = SkImageInfo::MakeN32Premul(onISize(), + inputCanvas->imageInfo().profileType()); SkSurfaceProps canvasProps(SkSurfaceProps::kLegacyFontHost_InitType); uint32_t gammaCorrect = inputCanvas->getProps(&canvasProps) ? canvasProps.flags() & SkSurfaceProps::kGammaCorrect_Flag : 0; diff --git a/gm/textblobrandomfont.cpp b/gm/textblobrandomfont.cpp index 58f0dc6bd6..2a6fc8e832 100644 --- a/gm/textblobrandomfont.cpp +++ b/gm/textblobrandomfont.cpp @@ -97,8 +97,8 @@ protected: canvas->drawColor(sk_tool_utils::color_to_565(SK_ColorWHITE)); - SkImageInfo info = SkImageInfo::MakeN32(kWidth, kHeight, kPremul_SkAlphaType, - sk_ref_sp(canvas->imageInfo().colorSpace())); + SkImageInfo info = SkImageInfo::MakeN32Premul(kWidth, kHeight, + canvas->imageInfo().profileType()); SkSurfaceProps canvasProps(SkSurfaceProps::kLegacyFontHost_InitType); uint32_t gammaCorrect = canvas->getProps(&canvasProps) ? canvasProps.flags() & SkSurfaceProps::kGammaCorrect_Flag : 0; diff --git a/gm/xfermodes3.cpp b/gm/xfermodes3.cpp index 642175e5a1..2b554b6c11 100644 --- a/gm/xfermodes3.cpp +++ b/gm/xfermodes3.cpp @@ -126,7 +126,7 @@ private: GrContext* context = baseCanvas->getGrContext(); SkImageInfo baseInfo = baseCanvas->imageInfo(); SkImageInfo info = SkImageInfo::Make(w, h, baseInfo.colorType(), baseInfo.alphaType(), - sk_ref_sp(baseInfo.colorSpace())); + baseInfo.profileType()); SkSurfaceProps canvasProps(SkSurfaceProps::kLegacyFontHost_InitType); baseCanvas->getProps(&canvasProps); return SkSurface::MakeRenderTarget(context, SkBudgeted::kNo, info, 0, &canvasProps); |