diff options
author | Matt Sarett <msarett@google.com> | 2017-04-28 11:15:22 -0400 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-04-28 15:49:04 +0000 |
commit | 68b8e3d50d0954eb5eeb7f625f06026c7fbd38c1 (patch) | |
tree | 3bfd232ad1dab38ea06fffdd761ea24d016be337 /gm | |
parent | 0acd7954a9e654d7e9c11a532eeeeb2f18a76152 (diff) |
Revert "Revert "Delete copyTo(Allocator), hide copyTo() behind flag""
This reverts commit 0122af08f6af0dee490e1a4f35b552377d0d4753.
Reason for revert: Fixed Android callsite
Original change's description:
> Revert "Delete copyTo(Allocator), hide copyTo() behind flag"
>
> This reverts commit d4a338f4d0a0cdc08d7d3668931c60997f0fa971.
>
> Reason for revert: Looks like I missed something I was supposed to delete in Android.
>
> Original change's description:
> > Delete copyTo(Allocator), hide copyTo() behind flag
> >
> > Replace uses of copyTo() in Skia.
> >
> > Bug: skia:6464
> > Change-Id: I921dc53a1c29a5176d18f05741f7c0b5a008e548
> > Reviewed-on: https://skia-review.googlesource.com/14502
> > Commit-Queue: Matt Sarett <msarett@google.com>
> > Reviewed-by: Mike Reed <reed@google.com>
> >
>
> TBR=msarett@google.com,reed@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Change-Id: I4d252940cc6a2462b030007055ea6c229471fc6e
> Reviewed-on: https://skia-review.googlesource.com/14602
> Reviewed-by: Matt Sarett <msarett@google.com>
> Commit-Queue: Matt Sarett <msarett@google.com>
>
TBR=msarett@google.com,reviews@skia.org,reed@google.com
Change-Id: I81659a820f79f1958fda23cb62513065b57db99d
Reviewed-on: https://skia-review.googlesource.com/14640
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Matt Sarett <msarett@google.com>
Diffstat (limited to 'gm')
-rw-r--r-- | gm/all_bitmap_configs.cpp | 11 | ||||
-rw-r--r-- | gm/animatedGif.cpp | 4 | ||||
-rw-r--r-- | gm/bitmapcopy.cpp | 2 | ||||
-rw-r--r-- | gm/bitmapfilters.cpp | 6 | ||||
-rw-r--r-- | gm/copyTo4444.cpp | 3 | ||||
-rw-r--r-- | gm/showmiplevels.cpp | 11 | ||||
-rw-r--r-- | gm/simpleaaclip.cpp | 2 |
7 files changed, 28 insertions, 11 deletions
diff --git a/gm/all_bitmap_configs.cpp b/gm/all_bitmap_configs.cpp index 7e9dfab522..98d6621c6b 100644 --- a/gm/all_bitmap_configs.cpp +++ b/gm/all_bitmap_configs.cpp @@ -14,8 +14,15 @@ #include "SkColorPriv.h" static SkBitmap copy_bitmap(const SkBitmap& src, SkColorType colorType) { + const SkBitmap* srcPtr = &src; + SkBitmap tmp(src); + if (kRGB_565_SkColorType == colorType) { + tmp.setAlphaType(kOpaque_SkAlphaType); + srcPtr = &tmp; + } + SkBitmap copy; - src.copyTo(©, colorType); + sk_tool_utils::copy_to(©, colorType, *srcPtr); copy.setImmutable(); return copy; } @@ -200,7 +207,7 @@ sk_sp<SkImage> make_not_native32_color_wheel() { const SkColorType ct = kBGRA_8888_SkColorType; #endif static_assert(ct != kN32_SkColorType, "BRGA!=RGBA"); - SkAssertResult(n32bitmap.copyTo(¬N32bitmap, ct)); + SkAssertResult(sk_tool_utils::copy_to(¬N32bitmap, ct, n32bitmap)); SkASSERT(notN32bitmap.colorType() == ct); return SkImage::MakeFromBitmap(notN32bitmap); } diff --git a/gm/animatedGif.cpp b/gm/animatedGif.cpp index c7871e0d12..dd08abfd36 100644 --- a/gm/animatedGif.cpp +++ b/gm/animatedGif.cpp @@ -6,6 +6,7 @@ */ #include "gm.h" +#include "sk_tool_utils.h" #include "SkAnimTimer.h" #include "SkCanvas.h" #include "SkCodec.h" @@ -59,7 +60,8 @@ private: && static_cast<size_t>(requiredFrame) < fFrames.size()); SkBitmap& requiredBitmap = fFrames[requiredFrame]; // For simplicity, do not try to cache old frames - if (requiredBitmap.getPixels() && requiredBitmap.copyTo(&bm)) { + if (requiredBitmap.getPixels() && + sk_tool_utils::copy_to(&bm, requiredBitmap.colorType(), requiredBitmap)) { opts.fHasPriorFrame = true; } } diff --git a/gm/bitmapcopy.cpp b/gm/bitmapcopy.cpp index 60eecf2ecd..7428c20b50 100644 --- a/gm/bitmapcopy.cpp +++ b/gm/bitmapcopy.cpp @@ -71,7 +71,7 @@ protected: draw_checks(&canvasTmp, 40, 40); for (unsigned i = 0; i < NUM_CONFIGS; ++i) { - src.copyTo(&fDst[i], gColorTypes[i]); + sk_tool_utils::copy_to(&fDst[i], gColorTypes[i], src); } canvas->clear(sk_tool_utils::color_to_565(0xFFDDDDDD)); diff --git a/gm/bitmapfilters.cpp b/gm/bitmapfilters.cpp index 22e5d0943f..7dc969286b 100644 --- a/gm/bitmapfilters.cpp +++ b/gm/bitmapfilters.cpp @@ -68,9 +68,9 @@ static SkScalar draw_row(SkCanvas* canvas, const SkBitmap& bm) { class FilterGM : public skiagm::GM { void onOnceBeforeDraw() override { make_bm(&fBM8); - fBM8.copyTo(&fBM4444, kARGB_4444_SkColorType); - fBM8.copyTo(&fBM16, kRGB_565_SkColorType); - fBM8.copyTo(&fBM32, kN32_SkColorType); + sk_tool_utils::copy_to(&fBM4444, kARGB_4444_SkColorType, fBM8); + sk_tool_utils::copy_to(&fBM16, kRGB_565_SkColorType, fBM8); + sk_tool_utils::copy_to(&fBM32, kN32_SkColorType, fBM8); } public: diff --git a/gm/copyTo4444.cpp b/gm/copyTo4444.cpp index 64f2c60746..f593a19de8 100644 --- a/gm/copyTo4444.cpp +++ b/gm/copyTo4444.cpp @@ -6,6 +6,7 @@ */ #include "gm.h" +#include "sk_tool_utils.h" #include "Resources.h" #include "SkCanvas.h" @@ -37,7 +38,7 @@ protected: return; } canvas->drawBitmap(bm, 0, 0); - SkAssertResult(bm.copyTo(&bm4444, kARGB_4444_SkColorType)); + SkAssertResult(sk_tool_utils::copy_to(&bm4444, kARGB_4444_SkColorType, bm)); canvas->drawBitmap(bm4444, SkIntToScalar(bm.width()), 0); } diff --git a/gm/showmiplevels.cpp b/gm/showmiplevels.cpp index e5374e4044..3e2091fd6b 100644 --- a/gm/showmiplevels.cpp +++ b/gm/showmiplevels.cpp @@ -120,7 +120,7 @@ protected: static void DrawAndFrame(SkCanvas* canvas, const SkBitmap& orig, SkScalar x, SkScalar y) { SkBitmap bm; - orig.copyTo(&bm); + sk_tool_utils::copy_to(&bm, orig.colorType(), orig); apply_gamma(bm); canvas->drawBitmap(bm, x, y, nullptr); @@ -218,7 +218,14 @@ void copy_to(SkBitmap* dst, SkColorType dstColorType, const SkBitmap& src) { return sk_tool_utils::copy_to_g8(dst, src); } - src.copyTo(dst, dstColorType); + const SkBitmap* srcPtr = &src; + SkBitmap tmp(src); + if (kRGB_565_SkColorType == dstColorType) { + tmp.setAlphaType(kOpaque_SkAlphaType); + srcPtr = &tmp; + } + + sk_tool_utils::copy_to(dst, dstColorType, *srcPtr); } /** diff --git a/gm/simpleaaclip.cpp b/gm/simpleaaclip.cpp index 8f6c5c95c5..4c7407dedb 100644 --- a/gm/simpleaaclip.cpp +++ b/gm/simpleaaclip.cpp @@ -27,7 +27,7 @@ static void paint_rgn(SkCanvas* canvas, const SkAAClip& clip, // need to copy for deferred drawing test to work SkBitmap bm2; - bm.deepCopyTo(&bm2); + sk_tool_utils::copy_to(&bm2, bm.colorType(), bm); canvas->drawBitmap(bm2, SK_Scalar1 * mask.fBounds.fLeft, |