aboutsummaryrefslogtreecommitdiffhomepage
path: root/gm
diff options
context:
space:
mode:
authorGravatar epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81>2013-01-02 15:53:25 +0000
committerGravatar epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81>2013-01-02 15:53:25 +0000
commit3aa3358c0334405482f056876b84deab156a4398 (patch)
tree52a7cc57e40c67521cea53d9f900c93405a7d175 /gm
parentdf194a47d21732af5671b358854b539233aba1e7 (diff)
Add more warnings about https://code.google.com/p/skia/issues/detail?id=677 ('make tools/tests/run.sh work cross-platform')
git-svn-id: http://skia.googlecode.com/svn/trunk@6965 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'gm')
-rwxr-xr-xgm/tests/rebaseline.sh6
-rwxr-xr-xgm/tests/run.sh7
2 files changed, 11 insertions, 2 deletions
diff --git a/gm/tests/rebaseline.sh b/gm/tests/rebaseline.sh
index be8ccf291b..71af20f440 100755
--- a/gm/tests/rebaseline.sh
+++ b/gm/tests/rebaseline.sh
@@ -6,6 +6,12 @@
#
# YOU MUST RE-RUN THIS UNTIL THE SELF-TESTS SUCCEED!
# (It takes one run for each failing call to gm_test in run.sh)
+#
+# TODO: currently, this must be run on Linux to generate baselines that match
+# the ones on the housekeeper bot (which runs on Linux... see
+# http://70.32.156.51:10117/builders/Skia_PerCommit_House_Keeping/builds/1417/steps/RunGmSelfTests/logs/stdio )
+# See https://code.google.com/p/skia/issues/detail?id=677
+# ('make tools/tests/run.sh work cross-platform')
function replace_expected_with_actual {
# Delete all the expected output files
diff --git a/gm/tests/run.sh b/gm/tests/run.sh
index 46c8929114..c23e145f0a 100755
--- a/gm/tests/run.sh
+++ b/gm/tests/run.sh
@@ -5,8 +5,11 @@
# These tests are run by the Skia_PerCommit_House_Keeping bot at every commit,
# so make sure that they still pass when you make changes to gm!
#
-# TODO: Even though these tests are passing on the Skia_PerCommit_House_Keeping
-# bot (which runs on Linux), they fail when I run them on my Mac.
+# TODO: currently, this only passes on Linux (which is the platform that
+# the housekeeper bot runs on, e.g.
+# http://70.32.156.51:10117/builders/Skia_PerCommit_House_Keeping/builds/1417/steps/RunGmSelfTests/logs/stdio )
+# See https://code.google.com/p/skia/issues/detail?id=677
+# ('make tools/tests/run.sh work cross-platform')
# Ideally, these tests should pass on all development platforms...
# otherwise, how can developers be expected to test them before committing a
# change?