aboutsummaryrefslogtreecommitdiffhomepage
path: root/gm
diff options
context:
space:
mode:
authorGravatar epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81>2013-01-10 17:11:27 +0000
committerGravatar epoger@google.com <epoger@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81>2013-01-10 17:11:27 +0000
commit3499f3c0d939dd882f75519bd8aeb4a674b67e13 (patch)
treed05c0428d42fbab74a55db8a071e21c845024e8e /gm
parent59a6a2b98302adc4732fc26873043bad1a94e9f1 (diff)
gm: if no readPath is given, report all tests as "missing reference image" instead of "passed"
Review URL: https://codereview.appspot.com/7070066 git-svn-id: http://skia.googlecode.com/svn/trunk@7119 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'gm')
-rw-r--r--gm/gmmain.cpp6
-rw-r--r--gm/tests/outputs/no-readpath/output-expected/stdout2
2 files changed, 4 insertions, 4 deletions
diff --git a/gm/gmmain.cpp b/gm/gmmain.cpp
index 19adf2658d..57514f1a94 100644
--- a/gm/gmmain.cpp
+++ b/gm/gmmain.cpp
@@ -1432,10 +1432,10 @@ int tool_main(int argc, char** argv) {
// want to also tabulate pixel mismatches vs dimension mistmatches
// (or whatever else), we can do so.
testsRun++;
- if (ERROR_NONE == testErrors) {
- testsPassed++;
- } else if (ERROR_READING_REFERENCE_IMAGE & testErrors) {
+ if (!readPath || (ERROR_READING_REFERENCE_IMAGE & testErrors)) {
testsMissingReferenceImages++;
+ } else if (ERROR_NONE == testErrors) {
+ testsPassed++;
} else {
testsFailed++;
}
diff --git a/gm/tests/outputs/no-readpath/output-expected/stdout b/gm/tests/outputs/no-readpath/output-expected/stdout
index ca556457b1..4781221981 100644
--- a/gm/tests/outputs/no-readpath/output-expected/stdout
+++ b/gm/tests/outputs/no-readpath/output-expected/stdout
@@ -1,3 +1,3 @@
writing to gm/tests/outputs/no-readpath/output-actual/images
drawing... dashing2 [640 480]
-Ran 1 tests: 1 passed, 0 failed, 0 missing reference images
+Ran 1 tests: 0 passed, 0 failed, 1 missing reference images