diff options
author | herb <herb@google.com> | 2015-08-20 09:28:45 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-08-20 09:28:45 -0700 |
commit | 12d8472d31ea5edb636d7d5214db253570115c40 (patch) | |
tree | cbddb53ff11b359fd0a10c2aac3b04986f735255 /gm | |
parent | 877a52ae61f41f0b519a906ed2460d44746de8e1 (diff) |
Revert of Implement canComputeFastBounds() for image filters. (patchset #8 id:130001 of https://codereview.chromium.org/1296943002/ )
Reason for revert:
This causes a syntax error.
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/87819/steps/compile%20%28with%20patch%29/logs/stdio
Original issue's description:
> Implement canComputeFastBounds() for image filters.
>
> Image filters have never implemented this check, which means that
> filters which affect transparent black falsely claim they can compute
> their bounds.
>
> Implemented an affectsTransparentBlack() virtual for image
> filters, and a similar helper function for color filters.
>
> This will affect the following GMs: imagefiltersscaled
> (lighting, perlin noise now filter to clip),
> colorfilterimagefilter (new test case), imagefiltersclipped
> (perlin noise now filters to clip).
>
> Note: I de-inlined SkPaint::canComputeFastBounds() to avoid adding
> a dependency from SkPaint.h to SkImageFilter.h.h. Skia benches show
> no impact from this change, but will watch the perf bots carefully.
>
> BUG=4212
>
> Committed: https://skia.googlesource.com/skia/+/915881fe743f9a789037695f543bc6ea189cd0cb
TBR=reed@google.com,senorblanco@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=4212
Review URL: https://codereview.chromium.org/1300403003
Diffstat (limited to 'gm')
-rw-r--r-- | gm/colorfilterimagefilter.cpp | 8 | ||||
-rw-r--r-- | gm/imagefiltersscaled.cpp | 1 |
2 files changed, 1 insertions, 8 deletions
diff --git a/gm/colorfilterimagefilter.cpp b/gm/colorfilterimagefilter.cpp index 500450f61b..b34058f9d7 100644 --- a/gm/colorfilterimagefilter.cpp +++ b/gm/colorfilterimagefilter.cpp @@ -45,7 +45,7 @@ static SkImageFilter* make_grayscale(SkImageFilter* input = NULL) { static SkImageFilter* make_mode_blue(SkImageFilter* input = NULL) { SkAutoTUnref<SkColorFilter> filter( - SkColorFilter::CreateModeFilter(SK_ColorBLUE, SkXfermode::kSrc_Mode)); + SkColorFilter::CreateModeFilter(SK_ColorBLUE, SkXfermode::kSrcIn_Mode)); return SkColorFilterImageFilter::Create(filter, input); } @@ -120,12 +120,6 @@ protected: drawClippedRect(canvas, r, paint, 3); canvas->translate(FILTER_WIDTH + MARGIN, 0); } - { - SkAutoTUnref<SkImageFilter> blue(make_mode_blue()); - paint.setImageFilter(blue.get()); - drawClippedRect(canvas, r, paint, 5); - canvas->translate(FILTER_WIDTH + MARGIN, 0); - } } private: diff --git a/gm/imagefiltersscaled.cpp b/gm/imagefiltersscaled.cpp index 2e4756a9b3..e7a68d747d 100644 --- a/gm/imagefiltersscaled.cpp +++ b/gm/imagefiltersscaled.cpp @@ -131,7 +131,6 @@ protected: paint.setAntiAlias(true); canvas->save(); canvas->scale(scales[j].fX, scales[j].fY); - canvas->clipRect(r); if (5 == i) { canvas->translate(SkIntToScalar(-32), 0); } else if (6 == i) { |