diff options
| author |  mtklein <mtklein@chromium.org> | 2016-04-06 15:01:57 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-04-06 15:01:57 -0700 |
| commit | 11064dfeb49daa64bd4e539284b9a6d1b78d6e5e (patch) | |
| tree | ee5f9ae275a3e59a2ff853a25e3b846db0e5e61e /gm | |
| parent | deacc97bc63513b5eacaf21f858727f6e8b98ce5 (diff) | |
Fix lazy coding in ViaSingletonPictures.
I was using SkRect::MakeLargest() as bounds, which is sort of nutso,
as that clearly is way out of bounds for how big a picture can feasibly
be, i.e. something closer to SkIRect::MakeLargest().
This was causing spurious quick rejects in drawPatch(). I didn't really
look much deeper to figure out why. It's easy enough to just feed it the
proper bounds of the entire content.
This means patch_primitive draws correctly in sp-8888 mode.
I also noticed the GM was too small... it clipped off most of its content.
So I've made it larger.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1865143002
Review URL: https://codereview.chromium.org/1865143002
Diffstat (limited to 'gm')
| -rw-r--r-- | gm/patch.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gm/patch.cpp b/gm/patch.cpp index 40eb46f4b6..6b2d298468 100644 --- a/gm/patch.cpp +++ b/gm/patch.cpp @@ -63,7 +63,7 @@ static void draw_control_points(SkCanvas* canvas, const SkPoint cubics[12]) { canvas->drawPoints(SkCanvas::kPoints_PointMode, 2, right + 1, paint); } -DEF_SIMPLE_GM(patch_primitive, canvas, 800, 800) { +DEF_SIMPLE_GM(patch_primitive, canvas, 1500, 1100) { SkPaint paint; // The order of the colors and points is clockwise starting at upper-left corner. |