diff options
| author |  mtklein <mtklein@chromium.org> | 2014-06-03 09:04:33 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2014-06-03 09:04:34 -0700 |
| commit | 04cd368cb41f0dd7bce119f61d0ff29d57e22d17 (patch) | |
| tree | 5747a914a581c6bf1b54b077195a57613fc8a89b /gm | |
| parent | 14052a0b5adfe2282e6ca70be71ab72a59e5e784 (diff) | |
Fix memory leak in etc1bitmap GM.
We never drop our first ref on fileData. (All our ref counts start at one).
SkAutoTUnref<T> is almost always the right thing to use for refcounted types.
BUG=skia:2635
R=krajcevski@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/310793003
Diffstat (limited to 'gm')
| -rw-r--r-- | gm/etc1bitmap.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gm/etc1bitmap.cpp b/gm/etc1bitmap.cpp index bb8ca6f406..f61b514ecb 100644 --- a/gm/etc1bitmap.cpp +++ b/gm/etc1bitmap.cpp @@ -38,7 +38,7 @@ protected: SkString filename = SkOSPath::SkPathJoin( INHERITED::gResourcePath.c_str(), "mandrill_512.pkm"); - SkData *fileData = SkData::NewFromFileName(filename.c_str()); + SkAutoTUnref<SkData> fileData(SkData::NewFromFileName(filename.c_str())); if (NULL == fileData) { SkDebugf("Could not open the file. Did you forget to set the resourcePath?\n"); return; |