diff options
| author |  epoger <epoger@google.com> | 2014-08-20 08:00:28 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2014-08-20 08:00:28 -0700 |
| commit | 2c4352bb9db02db70b829f96f397faa80fade220 (patch) | |
| tree | b18ff06d99190d6dccd81d6cf241f233f1da7ddc /gm/rebaseline_server/static/live-view.html | |
| parent | 802aa8c15b7e88f5c702c2d10b33b3787dd38f47 (diff) | |
rebaseline_server: allow users to generate SKP diff patches on a shared instance
This will allow developers to maintain SKP baselines without ever running their
own rebaseline_server instance!
For now, the developer must manually apply the resulting patchset to his local
Skia checkout to actually modify expectations; in the near future, we hope to
make the UI upload the patchset to Rietveld on the user's behalf.
BUG=skia:1918
NOTRY=true
R=stephana@google.com, rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/487853004
Diffstat (limited to 'gm/rebaseline_server/static/live-view.html')
| -rw-r--r-- | gm/rebaseline_server/static/live-view.html | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/gm/rebaseline_server/static/live-view.html b/gm/rebaseline_server/static/live-view.html index 44cbd0d337..6c158a6e7e 100644 --- a/gm/rebaseline_server/static/live-view.html +++ b/gm/rebaseline_server/static/live-view.html @@ -170,14 +170,11 @@ <!-- Submission UI that we only show in the Pending Approval tab. --> <div ng-show="'Pending Approval' == viewingTab"> - <div style="font-size:20px"> - TODO(epoger): We don't yet support submitting new SKP expectations. - </div> <div style="display:inline-block"> <button style="font-size:20px" ng-click="submitApprovals(filteredImagePairs)" - ng-disabled="true || submitPending || (filteredImagePairs.length == 0)"> - Update these {{filteredImagePairs.length}} expectations on the server + ng-disabled="submitPending || (filteredImagePairs.length == 0)"> + Get a patchfile to update these {{filteredImagePairs.length}} expectations </button> </div> <div style="display:inline-block"> @@ -201,6 +198,12 @@ </li> </ul> </div> + <div ng-show="diffResults"> + <p> + Here is the patch to apply to your local checkout: + <br> + <textarea rows="8" cols="50">{{diffResults}}</textarea> + </div> </div> <p> |