diff options
author | reed <reed@google.com> | 2016-03-13 13:01:57 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-03-13 13:01:57 -0700 |
commit | 9283d20afc27571f7a871d1bd1100dd5df584941 (patch) | |
tree | 3688fa1847d47e1f2493b040bbe91594f6274cf0 /gm/pictureshadertile.cpp | |
parent | ce563cdd48ec7ce4e0420dd88760df9be9dba50c (diff) |
Revert of more shader-->sp conversions (patchset #5 id:80001 of https://codereview.chromium.org/1789633002/ )
Reason for revert:
seems to have changed pictureshadertile
Original issue's description:
> more shader-->sp conversions
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1789633002
>
> Committed: https://skia.googlesource.com/skia/+/ce563cdd48ec7ce4e0420dd88760df9be9dba50c
TBR=fmalita@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1790353002
Diffstat (limited to 'gm/pictureshadertile.cpp')
-rw-r--r-- | gm/pictureshadertile.cpp | 18 |
1 files changed, 10 insertions, 8 deletions
diff --git a/gm/pictureshadertile.cpp b/gm/pictureshadertile.cpp index 68e65f87bb..30776c338b 100644 --- a/gm/pictureshadertile.cpp +++ b/gm/pictureshadertile.cpp @@ -95,14 +95,14 @@ protected: SkPictureRecorder recorder; SkCanvas* pictureCanvas = recorder.beginRecording(kPictureSize, kPictureSize); draw_scene(pictureCanvas, kPictureSize); - sk_sp<SkPicture> picture(recorder.endRecording()); + SkAutoTUnref<SkPicture> picture(recorder.endRecording()); SkPoint offset = SkPoint::Make(100, 100); pictureCanvas = recorder.beginRecording(SkRect::MakeXYWH(offset.x(), offset.y(), kPictureSize, kPictureSize)); pictureCanvas->translate(offset.x(), offset.y()); draw_scene(pictureCanvas, kPictureSize); - sk_sp<SkPicture> offsetPicture(recorder.endRecording()); + SkAutoTUnref<SkPicture> offsetPicture(recorder.endRecording()); for (unsigned i = 0; i < SK_ARRAY_COUNT(tiles); ++i) { SkRect tile = SkRect::MakeXYWH(tiles[i].x * kPictureSize, @@ -115,18 +115,20 @@ protected: localMatrix.postScale(kFillSize / (2 * kPictureSize), kFillSize / (2 * kPictureSize)); - sk_sp<SkPicture>& pictureRef = picture; + SkPicture* picturePtr = picture.get(); SkRect* tilePtr = &tile; if (tile == SkRect::MakeWH(kPictureSize, kPictureSize)) { // When the tile == picture bounds, exercise the picture + offset path. - pictureRef = offsetPicture; + picturePtr = offsetPicture.get(); tilePtr = nullptr; } - fShaders[i] = SkShader::MakePictureShader(pictureRef, SkShader::kRepeat_TileMode, - SkShader::kRepeat_TileMode, &localMatrix, - tilePtr); + fShaders[i].reset(SkShader::CreatePictureShader(picturePtr, + SkShader::kRepeat_TileMode, + SkShader::kRepeat_TileMode, + &localMatrix, + tilePtr)); } } @@ -148,7 +150,7 @@ protected: } private: - sk_sp<SkShader> fShaders[SK_ARRAY_COUNT(tiles)]; + SkAutoTUnref<SkShader> fShaders[SK_ARRAY_COUNT(tiles)]; typedef GM INHERITED; }; |