diff options
| author |  mtklein <mtklein@chromium.org> | 2016-09-01 11:24:54 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-09-01 11:24:54 -0700 |
| commit | dbfd7ab10883f173f5c1b653a233e18dc6142002 (patch) | |
| tree | a69ab168400f1d270d6047e1d8edf956cb6e5442 /gm/convexpolyeffect.cpp | |
| parent | 0b629ec73210161a6ba869a44a3c4ffd5a27dab9 (diff) | |
Replace a lot of 'static const' with 'constexpr' or 'const'.
'static const' means, there must be at most one of these, and initialize it at
compile time if possible or runtime if necessary. This leads to unexpected
code execution, and TSAN* will complain about races on the guard variables.
Generally 'constexpr' or 'const' are better choices. Neither can cause races:
they're either intialized at compile time (constexpr) or intialized each time
independently (const).
This CL prefers constexpr where possible, and uses const where not. It even
prefers constexpr over const where they don't make a difference... I want to have
lots of examples of constexpr for people to see and mimic.
The scoped-to-class static has nothing to do with any of this, and is not changed.
* Not yet on the bots, which use an older TSAN.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300623005
Review-Url: https://codereview.chromium.org/2300623005
Diffstat (limited to 'gm/convexpolyeffect.cpp')
| -rw-r--r-- | gm/convexpolyeffect.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gm/convexpolyeffect.cpp b/gm/convexpolyeffect.cpp index a5c2904566..44471e5f13 100644 --- a/gm/convexpolyeffect.cpp +++ b/gm/convexpolyeffect.cpp @@ -110,7 +110,7 @@ protected: fPaths.addToTail(tri); SkPath ngon; - static const SkScalar kRadius = 50.f; + constexpr SkScalar kRadius = 50.f; const SkPoint center = { kRadius, kRadius }; for (int i = 0; i < GrConvexPolyEffect::kMaxEdges; ++i) { SkScalar angle = 2 * SK_ScalarPI * i / GrConvexPolyEffect::kMaxEdges; @@ -160,7 +160,7 @@ protected: } SkScalar y = 0; - static const SkScalar kDX = 12.f; + constexpr SkScalar kDX = 12.f; for (PathList::Iter iter(fPaths, PathList::Iter::kHead_IterStart); iter.get(); iter.next()) { |