diff options
| author |  bungeman@google.com <bungeman@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-04-16 15:24:31 +0000 |
|---|---|---|
| committer | bungeman@google.com <bungeman@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-04-16 15:24:31 +0000 |
| commit | 6f4cf2a19553b69d5bb10c5cd1005706a9fc6e22 (patch) | |
| tree | c9d1e9b49b408b5659cd3e2f4826e2287e540e20 /gm/bitmaprecttest.cpp | |
| parent | c4f2ecaa475756bda48684b1158ec6b8bbdd1016 (diff) | |
Remove 'friend SkRefCnt' from SkData.
https://codereview.chromium.org/13925021/
If a non-POD class does not provide a default destructor, one is
provided by teh compiler. GCC will do so, but only at the point where the
vtable is output; since BlockRef has no implementation its destructor is
never output, so there is no complaint. VC++, however, provides the
destructor implementation as soon as it sees the type. If the destructor
of BlockRef is ever defined an error will be reported (since the
destructor of SkData is private).
Declaring (but does not defining) a destructor for BlockRef fixes two
issues. First, it prevents a default destructor from being provided,
removing the VC++ error. Second, BlockRef now blocks access to the
destructor through '->'.
git-svn-id: http://skia.googlecode.com/svn/trunk@8697 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'gm/bitmaprecttest.cpp')
0 files changed, 0 insertions, 0 deletions