aboutsummaryrefslogtreecommitdiffhomepage
path: root/gm/arcto.cpp
diff options
context:
space:
mode:
authorGravatar bungeman <bungeman@google.com>2016-03-18 05:10:23 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2016-03-18 05:10:23 -0700
commit6f0749cfc7f93880bd6b8acfdc61900cda4a81fe (patch)
tree0fb054893ced56e90a8baf02400744b45a5b2321 /gm/arcto.cpp
parent5e1a24808415df2748822e8082e21a361362cdfe (diff)
Revert of allow one zero length dash (patchset #8 id:140001 of https://codereview.chromium.org/1805963002/ )
Reason for revert: Causes the dash bench to crash. Example crash: https://build.chromium.org/p/client.skia/builders/Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release/builds/5581/steps/nanobench/logs/stdio Original issue's description: > allow one zero length dash > > If the constructed stroke that represents a dash has a > single dash of length zero, and the end cap is square or > round, draw the cap. > > The old code initialized the initial dash length to zero, > making it ambiguous whether the first length is zero or > not. > > R=robertphillips@google.com > BUG=583299 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1805963002 > > Committed: https://skia.googlesource.com/skia/+/5e1a24808415df2748822e8082e21a361362cdfe TBR=robertphillips@google.com,reed@google.com,caryclark@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=583299 Review URL: https://codereview.chromium.org/1808303004
Diffstat (limited to 'gm/arcto.cpp')
-rw-r--r--gm/arcto.cpp21
1 files changed, 0 insertions, 21 deletions
diff --git a/gm/arcto.cpp b/gm/arcto.cpp
index 584fca3c4f..cd26eef35a 100644
--- a/gm/arcto.cpp
+++ b/gm/arcto.cpp
@@ -205,24 +205,3 @@ DEF_SIMPLE_GM(bug593049, canvas, 300, 300) {
canvas->drawPath(p, paint);
}
-
-#include "SkDashPathEffect.h"
-#include "SkPathMeasure.h"
-
-DEF_SIMPLE_GM(bug583299, canvas, 300, 300) {
- const char* d="M60,60 A50,50 0 0 0 160,60 A50,50 0 0 0 60,60z";
- SkPaint p;
- p.setStyle(SkPaint::kStroke_Style);
- p.setStrokeWidth(100);
- p.setAntiAlias(true);
- p.setColor(0xFF008200);
- p.setStrokeCap(SkPaint::kSquare_Cap);
- SkPath path;
- SkParsePath::FromSVGString(d, &path);
- SkPathMeasure meas(path, false);
- SkScalar length = meas.getLength();
- SkScalar intervals[] = {0, length };
- int intervalCount = (int) SK_ARRAY_COUNT(intervals);
- p.setPathEffect(SkDashPathEffect::Create(intervals, intervalCount, 0))->unref();
- canvas->drawPath(path, p);
-}