diff options
author | Mike Reed <reed@google.com> | 2016-11-12 08:06:55 -0600 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2016-11-13 18:31:13 +0000 |
commit | 5df4934b3e40cdc378e225d1dda39f015cae9bae (patch) | |
tree | f0871dcbca35730333ad3b14115e6a14987fac7b /gm/aaclip.cpp | |
parent | f982cb37e3092e7a69c13a12ec09806ceff5af45 (diff) |
Revert[2] "Change SkCanvas to *not* inherit from SkRefCnt"
Changes over original:
- conditionalize ownership in SkPictureRecorder
- conditionalize ownership in SkCanvasStateUtils
This reverts commit b613c266df48cf45296ecc23d1bd7098c84bb7ba.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4742
Change-Id: Ib25514d6f546c69b6650b5c957403b04f7380dc2
Reviewed-on: https://skia-review.googlesource.com/4742
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Diffstat (limited to 'gm/aaclip.cpp')
-rw-r--r-- | gm/aaclip.cpp | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/gm/aaclip.cpp b/gm/aaclip.cpp index dd83b7c730..683f5ff960 100644 --- a/gm/aaclip.cpp +++ b/gm/aaclip.cpp @@ -8,6 +8,7 @@ #include "gm.h" #include "SkCanvas.h" #include "SkPath.h" +#include "SkMakeUnique.h" static void do_draw(SkCanvas* canvas, const SkRect& r) { SkPaint paint; @@ -166,14 +167,14 @@ DEF_GM(return new AAClipGM;) #ifdef SK_BUILD_FOR_MAC -static SkCanvas* make_canvas(const SkBitmap& bm) { +static std::unique_ptr<SkCanvas> make_canvas(const SkBitmap& bm) { const SkImageInfo& info = bm.info(); if (info.bytesPerPixel() == 4) { - return SkCanvas::NewRasterDirectN32(info.width(), info.height(), - (SkPMColor*)bm.getPixels(), - bm.rowBytes()); + return SkCanvas::MakeRasterDirectN32(info.width(), info.height(), + (SkPMColor*)bm.getPixels(), + bm.rowBytes()); } else { - return new SkCanvas(bm); + return skstd::make_unique<SkCanvas>(bm); } } @@ -182,7 +183,6 @@ static void test_image(SkCanvas* canvas, const SkImageInfo& info) { SkBitmap bm; bm.allocPixels(info); - sk_sp<SkCanvas> newc(make_canvas(bm)); if (info.isOpaque()) { bm.eraseColor(SK_ColorGREEN); } else { @@ -192,7 +192,7 @@ static void test_image(SkCanvas* canvas, const SkImageInfo& info) { SkPaint paint; paint.setAntiAlias(true); paint.setColor(SK_ColorBLUE); - newc->drawCircle(50, 50, 49, paint); + make_canvas(bm)->drawCircle(50, 50, 49, paint); canvas->drawBitmap(bm, 10, 10); CGImageRef image = SkCreateCGImageRefWithColorspace(bm, nullptr); |