diff options
| author |  commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-05-16 13:49:08 +0000 |
|---|---|---|
| committer | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-05-16 13:49:08 +0000 |
| commit | e2b193ca5c76f01f8e12b4a92e9bd6ccb3ed4280 (patch) | |
| tree | 6fdc1c9c9bbfb0b7be6854a9e6993df145c31792 /experimental | |
| parent | dbe0cd13a0e1f437b81f1a63055da6e0fc3b0673 (diff) | |
Revert of remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/)
Reason for revert:
does not address all legacy callsites in chrome.
e.g.
[13:45:32.091872] ../../ui/native_theme/native_theme_base.cc:608:76: error: no matching function for call to ‘SkGradientShader::CreateLinear(SkPoint [3], SkColor [3], NULL, int, SkShader::TileMode, NULL)’
[13:45:32.091919] gradient_bounds, colors, NULL, 3, SkShader::kClamp_TileMode, NULL));
Original issue's description:
> remove unused (by clients) SkUnitMapper
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14761
R=robertphillips@google.com, scroggo@google.com, george@mozilla.com
TBR=george@mozilla.com, robertphillips@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/287063009
git-svn-id: http://skia.googlecode.com/svn/trunk@14763 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'experimental')
| -rw-r--r-- | experimental/SkiaExamples/HelloSkiaExample.cpp | 6 | ||||
| -rw-r--r-- | experimental/webtry/templates/template.cpp | 1 |
2 files changed, 6 insertions, 1 deletions
diff --git a/experimental/SkiaExamples/HelloSkiaExample.cpp b/experimental/SkiaExamples/HelloSkiaExample.cpp index 6fd2624c18..0b6c790460 100644 --- a/experimental/SkiaExamples/HelloSkiaExample.cpp +++ b/experimental/SkiaExamples/HelloSkiaExample.cpp @@ -13,6 +13,7 @@ #include "SkDraw.h" #include "SkGradientShader.h" #include "SkGraphics.h" +#include "SkUnitMappers.h" class HelloSkia : public SkExample { public: @@ -49,9 +50,12 @@ protected: }; SkColor linearColors[] = {SK_ColorGREEN, SK_ColorBLACK}; + SkUnitMapper* linearMapper = new SkDiscreteMapper(100); + SkAutoUnref lm_deleter(linearMapper); + SkShader* shader = SkGradientShader::CreateLinear( linearPoints, linearColors, NULL, 2, - SkShader::kMirror_TileMode); + SkShader::kMirror_TileMode, linearMapper); SkAutoUnref shader_deleter(shader); paint.setShader(shader); diff --git a/experimental/webtry/templates/template.cpp b/experimental/webtry/templates/template.cpp index 67d2c04dc9..5b017f0dff 100644 --- a/experimental/webtry/templates/template.cpp +++ b/experimental/webtry/templates/template.cpp @@ -150,6 +150,7 @@ #include "SkTSearch.h" #include "SkTypeface.h" #include "SkTypes.h" +#include "SkUnitMapper.h" #include "SkUnPreMultiply.h" #include "SkUtils.h" #include "SkWeakRefCnt.h" |