aboutsummaryrefslogtreecommitdiffhomepage
path: root/experimental/sksg/SkSGGroup.h
diff options
context:
space:
mode:
authorGravatar Florin Malita <fmalita@chromium.org>2018-01-03 16:17:29 -0500
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2018-01-04 00:59:20 +0000
commitc75e2401a82640c35b0b5f80a5684d0892904530 (patch)
tree0742a71071c9b92399a1182ec20ebfc69f8918f9 /experimental/sksg/SkSGGroup.h
parent5a59c26193272825e814b50f7d9856c1b122531f (diff)
[sksg] Refine invalidation logic
We need to discriminate between nodes whose bounds updates contribute to the dirty region, and nodes whose bounds changes do not. E.g. animated shape in a group: the animated shape node bounds should yield damage, but the ancestor group bounds should not. To accomplish this, we refine the invalidation state: 1) self invalidation == the node itself was invalidated, and its bounds updates yield damage. 2) descendant invalidation == the node has some (self-)invalidated descendant, but its own bounds are not contributing damage. Also: * hoist the bounding box invalidation logic into the base class (Node::revalidate) and update to respect the states described above. * remove (now-redundant) GeometryNode bbox logic. * update revalidation methods to return the node bbox instead of void TBR= Change-Id: I8023d1793fb501c945a53f2dc2d2983e5b620ade Reviewed-on: https://skia-review.googlesource.com/90581 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
Diffstat (limited to 'experimental/sksg/SkSGGroup.h')
-rw-r--r--experimental/sksg/SkSGGroup.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/experimental/sksg/SkSGGroup.h b/experimental/sksg/SkSGGroup.h
index 2ed9d0ecb5..f9126ea37f 100644
--- a/experimental/sksg/SkSGGroup.h
+++ b/experimental/sksg/SkSGGroup.h
@@ -31,7 +31,7 @@ protected:
~Group() override;
void onRender(SkCanvas*) const override;
- void onRevalidate(InvalidationController*, const SkMatrix&) override;
+ SkRect onRevalidate(InvalidationController*, const SkMatrix&) override;
private:
SkTArray<sk_sp<RenderNode>, true> fChildren;