diff options
| author |  rmistry <rmistry@google.com> | 2014-06-23 05:39:26 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2014-06-23 05:39:26 -0700 |
| commit | abc9bb55ddfeb4b1a7acc335a34841fddcd22d27 (patch) | |
| tree | cca0e3b87520a5defbb581e91f56117e1c55aefe /expectations/gm/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug | |
| parent | 4a995dfff2ecf91e8bf999d77e3218cec596232c (diff) | |
Revert of Fix SkPaint::measureText for stroked hairline text (https://codereview.chromium.org/335603003/)
Reason for revert:
Caused many shadertext GM failures
Original issue's description:
> Fix SkPaint::measureText for stroked hairline text
>
> SkPaint::measureText and text drawing used different criteria for
> determining whether text should be drawn as paths or not.
>
> Adds tests glyph_pos_(h/n)_(s/f/b) to test the text rendering and the glyph
> positioning in the rendering. Mainly added in order to define what is the
> expected text rendering when hairline stroke is used with various transform
> options.
>
> The testcase also tries to note or highlight the fact that SkPaint::measureText
> is not expected to produce intuitively matching results when compared to a
> rendering, if the rendering is done so that the device ends up having a device
> transform.
>
> This fixes the glyph_pos_h_s (hairline, stroked) test-case.
>
> Ignore shadertext2_pdf-poppler.png gm on
> Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug temporarily, as that fails.
>
> Committed: https://skia.googlesource.com/skia/+/196af738027c5e18c3eb792dbcaf90ef27821793
R=jvanverth@google.com, reed@google.com, kkinnunen@nvidia.com
TBR=jvanverth@google.com, kkinnunen@nvidia.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/354433002
Diffstat (limited to 'expectations/gm/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug')
| -rw-r--r-- | expectations/gm/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug/expected-results.json | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/expectations/gm/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug/expected-results.json b/expectations/gm/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug/expected-results.json index 30558811de..09d6c5810e 100644 --- a/expectations/gm/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug/expected-results.json +++ b/expectations/gm/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug/expected-results.json @@ -9210,7 +9210,6 @@ 5483462587049856153 ] ], - "ignore-failure": true, "reviewed-by-human": true }, "shadertext3_565.png": { @@ -10861,4 +10860,4 @@ "reviewed-by-human": false } } -} +}
\ No newline at end of file |