diff options
author | Cary Clark <caryclark@skia.org> | 2018-04-03 08:43:27 -0400 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-04-03 16:09:56 +0000 |
commit | 186d08f621efcaf9960ffe4a1dd9e6703de8a698 (patch) | |
tree | 7087f2b1a18ef61e26103389a3aab051c9d923f3 /docs/SkIRect_Reference.bmh | |
parent | ba31640427659ea2c096be1a26976e34348619cf (diff) |
fix bugs exposed by documenting SkImageInfo
- More rigorous symbol identification creates additional
links, and finds spurious errors like unnecessary
parentheses.
- Fixed code to allow preprocessor directives in
#Code blocks (still more to do).
- Fixed examples waiting on fiddle updates.
- Make SkImageInfo officially documented (update in status.json).
- Fixed enum indentation.
Docs-Preview: https://skia.org/?cl=115656
Bug: skia:6898
Change-Id: Ifcf5cfd3f6c03b3b83155c898b2b035a2f3d443c
Reviewed-on: https://skia-review.googlesource.com/115656
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
Diffstat (limited to 'docs/SkIRect_Reference.bmh')
-rw-r--r-- | docs/SkIRect_Reference.bmh | 24 |
1 files changed, 9 insertions, 15 deletions
diff --git a/docs/SkIRect_Reference.bmh b/docs/SkIRect_Reference.bmh index 45b636082d..1e59578310 100644 --- a/docs/SkIRect_Reference.bmh +++ b/docs/SkIRect_Reference.bmh @@ -420,11 +420,9 @@ overflow in its calculation. #Return fRight minus fLeft cast to int64_t ## -#Bug 7489 -# width64 is not yet visible to fiddle -#NoExample +#Example SkIRect large = { -2147483647, 1, 2147483644, 2 }; -SkDebugf("width: %d wdith64: %lld\n", large.width(), large.width64()); +SkDebugf("width: %d width64: %lld\n", large.width(), large.width64()); #StdOut width: -5 width64: 4294967291 ## @@ -472,9 +470,7 @@ overflow in its calculation. #Return fBottom minus fTop cast to int64_t ## -#Bug 7489 -# height64 not yet visible to fiddle -#NoExample +#Example SkIRect large = { 1, -2147483647, 2, 2147483644 }; SkDebugf("height: %d height64: %lld\n", large.height(), large.height64()); #StdOut @@ -623,16 +619,14 @@ width64() or height64(). #Return true if width64() or height64() are zero or negative ## -#Bug 7489 -# isEmpty64 not yet visible to fiddle -#NoExample +#Example SkIRect tests[] = {{20, 40, 10, 50}, {20, 40, 20, 50}}; for (auto rect : tests) { -SkDebugf("rect: {%d, %d, %d, %d} is" "%s empty\n", rect.left(), rect.top(), rect.right(), -rect.bottom(), isEmpty64() ? "" : " not"); -rect.sort(); -SkDebugf("sorted: {%d, %d, %d, %d} is" "%s empty\n", rect.left(), rect.top(), rect.right(), -rect.bottom(), isEmpty64() ? "" : " not"); + SkDebugf("rect: {%d, %d, %d, %d} is" "%s empty\n", rect.left(), rect.top(), rect.right(), + rect.bottom(), rect.isEmpty64() ? "" : " not"); + rect.sort(); + SkDebugf("sorted: {%d, %d, %d, %d} is" "%s empty\n", rect.left(), rect.top(), rect.right(), + rect.bottom(), rect.isEmpty64() ? "" : " not"); } #StdOut rect: {20, 40, 10, 50} is empty |