diff options
| author |  scroggo <scroggo@chromium.org> | 2016-10-24 13:48:49 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-10-24 13:48:49 -0700 |
| commit | 6e8c68e2423e3042e54d6c215f4c43dbf9916839 (patch) | |
| tree | 0ceaead306cb94df2f1357262b6ac62192f15123 /dm | |
| parent | 49f57123eb053b82c95078592ad82f2a628964f7 (diff) | |
Differentiate animated image results
Prior to this CL, a kAnimated_Mode CodecSrc (which draws a strip of
all frames in an image) has the same name as a non-animated one. This
means that Gold compares the two. Someone triaging will see two very
different images (a strip versus a single image) and think one of them
is wrong.
With this change, the two will have different names so they will not
be compared with one another.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2446543003
Review-Url: https://codereview.chromium.org/2446543003
Diffstat (limited to 'dm')
| -rw-r--r-- | dm/DMSrcSink.cpp | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/dm/DMSrcSink.cpp b/dm/DMSrcSink.cpp index 9efccd3042..06ca750734 100644 --- a/dm/DMSrcSink.cpp +++ b/dm/DMSrcSink.cpp @@ -721,8 +721,13 @@ SkISize CodecSrc::size() const { Name CodecSrc::name() const { if (1.0f == fScale) { - return SkOSPath::Basename(fPath.c_str()); + Name name = SkOSPath::Basename(fPath.c_str()); + if (fMode == kAnimated_Mode) { + name.append("_animated"); + } + return name; } + SkASSERT(fMode != kAnimated_Mode); return get_scaled_name(fPath, fScale); } |