diff options
| author |  mtklein <mtklein@google.com> | 2016-03-11 12:59:09 -0800 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-03-11 12:59:09 -0800 |
| commit | 51c8cfc64c7286ad8a392064cd376bb9974c7bc1 (patch) | |
| tree | 5e8df7dffffa7d77224a53d4a31a0cbecc2c9bb1 /dm | |
| parent | 98bd5b1e622047a62472c891cef5997a087edc22 (diff) | |
Revert of When not writing to file in DM, spew verbose output to stderr (patchset #1 id:1 of https://codereview.chromium.org/1788743002/ )
Reason for revert:
Looks like not all the bots are using --writePath (think, Valgrind, *SAN) so this causes those bots to spew like crazy.
Looks like we need to find a more explicit way to make this mode work.
Original issue's description:
> When not writing to file in DM, spew verbose output to stderr
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1788743002
>
> Committed: https://skia.googlesource.com/skia/+/40dec542cc12b354762bca2c0d68bc419f0cbebd
TBR=egdaniel@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1783603006
Diffstat (limited to 'dm')
| -rw-r--r-- | dm/DM.cpp | 10 |
1 files changed, 3 insertions, 7 deletions
@@ -1303,13 +1303,9 @@ int dm_main(); int dm_main() { setup_crash_handler(); - if (FLAGS_verbose) { - if(!FLAGS_writePath.isEmpty()) { - sk_mkdir(FLAGS_writePath[0]); - gVLog = freopen(SkOSPath::Join(FLAGS_writePath[0], "verbose.log").c_str(), "w", stderr); - } else { - gVLog = stderr; - } + if (FLAGS_verbose && !FLAGS_writePath.isEmpty()) { + sk_mkdir(FLAGS_writePath[0]); + gVLog = freopen(SkOSPath::Join(FLAGS_writePath[0], "verbose.log").c_str(), "w", stderr); } JsonWriter::DumpJson(); // It's handy for the bots to assume this is ~never missing. |