diff options
| author |  commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-02-25 20:02:09 +0000 |
|---|---|---|
| committer | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-02-25 20:02:09 +0000 |
| commit | 79e13260cf94427e6ccbfff8242bf85ed4c8187b (patch) | |
| tree | decbb335453684fcbe0c9dff854c2b1968226d8a /dm/DMReporter.h | |
| parent | 6bd250a2a340348434b7b16bd4e4b5da0f598e3e (diff) | |
Revert of Let DM run unit tests. (https://codereview.chromium.org/178273002/)
Reason for revert:
broke tests
Original issue's description:
> Let DM run unit tests.
> - refactor GYPs and a few flags
> - make GPU tests grab a thread-local GrContextFactory when needed as we do in DM for GMs
> - add a few more UI features to make DM more like tests
>
> I believe this makes the program 'tests' obsolete.
>
> It should be somewhat faster to run the two sets together than running the old binaries serially:
> - serial: tests 20s (3m18s CPU), dm 21s (3m01s CPU)
> - together: 27s (6m21s CPU)
>
> Next up is to incorporate benches. I'm only planning there on a single-pass sanity check, so that won't obsolete the program 'bench' just yet.
>
> Tested: out/Debug/tests && out/Debug/dm && echo ok
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=13586
R=bsalomon@google.com, mtklein@google.com, tfarina@chromium.org, mtklein@chromium.org
TBR=bsalomon@google.com, mtklein@chromium.org, mtklein@google.com, tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/179403010
git-svn-id: http://skia.googlecode.com/svn/trunk@13587 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'dm/DMReporter.h')
| -rw-r--r-- | dm/DMReporter.h | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/dm/DMReporter.h b/dm/DMReporter.h index 2bb4702178..4f4ad432d5 100644 --- a/dm/DMReporter.h +++ b/dm/DMReporter.h @@ -7,6 +7,7 @@ #include "SkTypes.h" // Used to report status changes including failures. All public methods are threadsafe. + namespace DM { class Reporter : SkNoncopyable { @@ -14,13 +15,15 @@ public: Reporter() : fStarted(0), fFinished(0) {} void start() { sk_atomic_inc(&fStarted); } - void finish(SkString name); - void fail(SkString msg); + void finish() { sk_atomic_inc(&fFinished); } + void fail(SkString name); int32_t started() const { return fStarted; } int32_t finished() const { return fFinished; } int32_t failed() const; + void updateStatusLine() const; + void getFailures(SkTArray<SkString>*) const; private: |