diff options
author | 2014-02-28 20:31:31 +0000 | |
---|---|---|
committer | 2014-02-28 20:31:31 +0000 | |
commit | ef57b7e65330d5f794a513630517907500f1c1d0 (patch) | |
tree | ad4e3a100ff3da01a22f7aa6bda8cf11cea609c5 /dm/DMBenchTask.h | |
parent | d1a7e2ec6ffb47243a31dc5c30b00fd7f700a339 (diff) |
DM: make GPU tasks multithreaded again. Big refactor.
The main meat of things is in SkThreadPool. We can now give SkThreadPool a
type for each thread to create and destroy on its local stack. It's TLS
without going through SkTLS.
I've split the DM tasks into CpuTasks that run on threads with no TLS, and
GpuTasks that run on threads with a thread local GrContextFactory.
The old CpuTask and GpuTask have been renamed to CpuGMTask and GpuGMTask.
Upshot: default run of out/Debug/dm goes from ~45 seconds to ~20 seconds.
BUG=skia:
R=bsalomon@google.com, mtklein@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/179233005
git-svn-id: http://skia.googlecode.com/svn/trunk@13632 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'dm/DMBenchTask.h')
-rw-r--r-- | dm/DMBenchTask.h | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/dm/DMBenchTask.h b/dm/DMBenchTask.h index 1e9bc9912e..ac7030b5f0 100644 --- a/dm/DMBenchTask.h +++ b/dm/DMBenchTask.h @@ -12,12 +12,11 @@ namespace DM { -class NonRenderingBenchTask : public Task { +class NonRenderingBenchTask : public CpuTask { public: NonRenderingBenchTask(const char* config, Reporter*, TaskRunner*, BenchRegistry::Factory); virtual void draw() SK_OVERRIDE; - virtual bool usesGpu() const SK_OVERRIDE { return false; } virtual bool shouldSkip() const SK_OVERRIDE; virtual SkString name() const SK_OVERRIDE { return fName; } @@ -26,12 +25,11 @@ private: const SkString fName; }; -class CpuBenchTask : public Task { +class CpuBenchTask : public CpuTask { public: CpuBenchTask(const char* config, Reporter*, TaskRunner*, BenchRegistry::Factory, SkColorType); virtual void draw() SK_OVERRIDE; - virtual bool usesGpu() const SK_OVERRIDE { return false; } virtual bool shouldSkip() const SK_OVERRIDE; virtual SkString name() const SK_OVERRIDE { return fName; } @@ -41,7 +39,7 @@ private: const SkColorType fColorType; }; -class GpuBenchTask : public Task { +class GpuBenchTask : public GpuTask { public: GpuBenchTask(const char* config, Reporter*, @@ -50,8 +48,7 @@ public: GrContextFactory::GLContextType, int sampleCount); - virtual void draw() SK_OVERRIDE; - virtual bool usesGpu() const SK_OVERRIDE { return true; } + virtual void draw(GrContextFactory*) SK_OVERRIDE; virtual bool shouldSkip() const SK_OVERRIDE; virtual SkString name() const SK_OVERRIDE { return fName; } |