Remove incremental draw optimization from SkDebugCanvas

The SkDebugCanvas can be (or is currently) being used to draw to multiple
different canvases. If this use-case is intended, then storing draw
-related state in the canvas causes bugs.

Remove incremental draw from SkDebugCanvas. It can only optimize the
case where draw command index is advanced, no other changes are done
and no visualization is used. This case is not that critical, as it
happens only once per new frame at most. It causes bugs, because
one SkDebugCanvas is used to draw to multiple canvases.

Leave the draw to canvas in same state as it was passed in.

This fixes the debugger bugs where:
 * Old, stale image would stay on the raster canvas when a new image is
 loaded. Also happened with resizes.

 * Proper image for overdraw filter would be visible only for the first
   frame

Review URL: https://codereview.chromium.org/844493003

1 files changed, 0 insertions, 8 deletions

diff --git a/debugger/SkDebugger.cpp b/debugger/SkDebugger.cpp
index 43823c12f0..fc61ddade3 100644
--- a/debugger/SkDebugger.cpp
+++ b/debugger/SkDebugger.cpp
@@ -49,19 +49,11 @@ SkPicture* SkDebugger::copyPicture() {
     fDebugCanvas->setOverdrawViz(false);
     bool pathOps = fDebugCanvas->getAllowSimplifyClip();
     fDebugCanvas->setAllowSimplifyClip(false);
-    int saveCount = fDebugCanvas->getOutstandingSaveCount();
-    fDebugCanvas->setOutstandingSaveCount(0);
 
     fDebugCanvas->draw(canvas);
 
-    int temp = fDebugCanvas->getOutstandingSaveCount();
-    for (int i = 0; i < temp; ++i) {
-        canvas->restore();
-    }
-
     fDebugCanvas->setMegaVizMode(vizMode);
     fDebugCanvas->setOverdrawViz(overDraw);
-    fDebugCanvas->setOutstandingSaveCount(saveCount);
     fDebugCanvas->setAllowSimplifyClip(pathOps);
 
     return recorder.endRecording();