aboutsummaryrefslogtreecommitdiffhomepage
path: root/bench
diff options
context:
space:
mode:
authorGravatar Derek Sollenberger <djsollen@google.com>2017-03-01 15:33:23 -0500
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2017-03-02 20:16:17 +0000
commitd7875f57bd5f17ac27f1cb2ace25224299ff2389 (patch)
treeb3592daa34cae97c713e1e6571c694ba5690a9ff /bench
parentc66390560ed845dbaf8656615f6a9524da643fa4 (diff)
Refactor SkLiteDL to no longer extend SkDrawable.
Change-Id: Ieaa849bceba0e98e4c99491c721fe945a0694e68 Reviewed-on: https://skia-review.googlesource.com/9111 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com> Reviewed-by: Stan Iliev <stani@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com>
Diffstat (limited to 'bench')
-rw-r--r--bench/PictureOverheadBench.cpp11
-rw-r--r--bench/RecordingBench.cpp10
-rw-r--r--bench/RecordingBench.h2
3 files changed, 12 insertions, 11 deletions
diff --git a/bench/PictureOverheadBench.cpp b/bench/PictureOverheadBench.cpp
index 27424a2439..1fea9e927c 100644
--- a/bench/PictureOverheadBench.cpp
+++ b/bench/PictureOverheadBench.cpp
@@ -25,14 +25,15 @@ struct PictureOverheadBench : public Benchmark {
void onDraw(int loops, SkCanvas*) override {
SkLiteRecorder lite;
SkPictureRecorder rec;
- for (int i = 0; i < loops; i++) {
- SkRect bounds{0,0, 2000,3000};
- sk_sp<SkLiteDL> liteDL;
+ SkIRect iBounds = {0,0, 2000,3000};
+ SkRect bounds = SkRect::Make(iBounds);
+
+ for (int i = 0; i < loops; i++) {
+ SkLiteDL liteDL;
SkCanvas* canvas;
if (kLite) {
- liteDL = SkLiteDL::New(bounds);
- lite.reset(liteDL.get());
+ lite.reset(&liteDL, iBounds);
canvas = &lite;
} else {
rec.beginRecording(bounds);
diff --git a/bench/RecordingBench.cpp b/bench/RecordingBench.cpp
index 69be911467..aa310523ad 100644
--- a/bench/RecordingBench.cpp
+++ b/bench/RecordingBench.cpp
@@ -40,9 +40,9 @@ RecordingBench::RecordingBench(const char* name, const SkPicture* pic, bool useB
{
// If we're recording into an SkLiteDL, also record _from_ one.
if (lite) {
- fDL = SkLiteDL::New(fSrc->cullRect());
+ fDL.reset(new SkLiteDL());
SkLiteRecorder r;
- r.reset(fDL.get());
+ r.reset(fDL.get(), fSrc->cullRect().roundOut());
fSrc->playback(&r);
}
}
@@ -51,10 +51,10 @@ void RecordingBench::onDraw(int loops, SkCanvas*) {
if (fDL) {
SkLiteRecorder rec;
while (loops --> 0) {
- sk_sp<SkLiteDL> dl = SkLiteDL::New(fSrc->cullRect());
- rec.reset(dl.get());
+ SkLiteDL dl;
+ rec.reset(&dl, fSrc->cullRect().roundOut());
fDL->draw(&rec);
- dl->makeThreadsafe();
+ dl.makeThreadsafe();
}
} else {
diff --git a/bench/RecordingBench.h b/bench/RecordingBench.h
index 4e34276a88..beaea3ee38 100644
--- a/bench/RecordingBench.h
+++ b/bench/RecordingBench.h
@@ -36,7 +36,7 @@ protected:
void onDraw(int loops, SkCanvas*) override;
private:
- sk_sp<SkLiteDL> fDL;
+ std::unique_ptr<SkLiteDL> fDL;
bool fUseBBH;
typedef PictureCentricBench INHERITED;