aboutsummaryrefslogtreecommitdiffhomepage
path: root/bench
diff options
context:
space:
mode:
authorGravatar bensong@google.com <bensong@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81>2012-11-30 04:42:59 +0000
committerGravatar bensong@google.com <bensong@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81>2012-11-30 04:42:59 +0000
commitcd63fb588ba09d97a94f9cfd77d436c6f3c308f5 (patch)
tree2dba689ae3c007586b88ededdde2df8d99837c5f /bench
parentc3d7d90973528527131c72549b10c2a21300e0ac (diff)
Adds BENCH_ALLOWED_NOISE to widen expected bench ranges.
This is especially useful for benches with small absolute value. Review URL: https://codereview.appspot.com/6842112 git-svn-id: http://skia.googlecode.com/svn/trunk@6633 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'bench')
-rwxr-xr-xbench/gen_skp_ranges.py14
1 files changed, 10 insertions, 4 deletions
diff --git a/bench/gen_skp_ranges.py b/bench/gen_skp_ranges.py
index e6c4295f91..575db375e4 100755
--- a/bench/gen_skp_ranges.py
+++ b/bench/gen_skp_ranges.py
@@ -35,6 +35,11 @@ from oauth2_plugin import oauth2_plugin
BENCH_UB = 1.1 # Allow for 10% room for normal variance on the up side.
BENCH_LB = 0.85
+# Further allow for a fixed amount of noise. This is especially useful for
+# benches of smaller absolute value. Keeping this value small will not affect
+# performance tunings.
+BENCH_ALLOWED_NOISE = 10
+
# List of platforms to track.
PLATFORMS = ['Mac_Float_Bench_32',
'Nexus10_4-1_Float_Bench_32',
@@ -56,8 +61,8 @@ Feel free to revise PLATFORMS for your own needs. The default is the most common
combination that we care most about. Platforms that did not run bench_pictures
in the given revision range will not have corresponding outputs.
Please check http://go/skpbench to choose a range that fits your needs.
-BENCH_UB and BENCH_LB can be changed to expand or narrow the permitted bench
-ranges without triggering buidbot alerts.
+BENCH_UB, BENCH_LB and BENCH_ALLOWED_NOISE can be changed to expand or narrow
+the permitted bench ranges without triggering buidbot alerts.
"""
HELP_STRING = """
Outputs expectation picture bench ranges for the latest revisions for the given
@@ -123,8 +128,9 @@ def OutputSkpBenchExpectations(rev_min, rev_max, representation_alg):
for key in keys:
bench_val = expectation_dic[key]
# Prints out expectation lines.
- print '%s,%.3f,%.3f,%.3f' % (key, bench_val, bench_val * BENCH_LB,
- bench_val * BENCH_UB)
+ print '%s,%.3f,%.3f,%.3f' % (key, bench_val,
+ bench_val * BENCH_LB - BENCH_ALLOWED_NOISE,
+ bench_val * BENCH_UB + BENCH_ALLOWED_NOISE)
def main():
"""Parses flags and outputs expected Skia picture bench results."""