diff options
author | Ben Wagner <bungeman@google.com> | 2018-07-12 13:30:47 -0400 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-07-12 20:59:20 +0000 |
commit | 9ec70c6bd3dfe6338fbbae9c0447a5cbae770a75 (patch) | |
tree | fe9dcd75fcc80ce6c3d52a6d18cf8639b8aed485 /bench | |
parent | c434ade20eba4a62c450b7ce33a89966fac9df62 (diff) |
Remove SkSafeSetNull.
Update all users to sk_sp.
Change-Id: I6453b9456b9a8f9e2b756381797f1382ef9e6561
Reviewed-on: https://skia-review.googlesource.com/141052
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Diffstat (limited to 'bench')
-rw-r--r-- | bench/SKPBench.cpp | 13 | ||||
-rw-r--r-- | bench/SKPBench.h | 4 |
2 files changed, 8 insertions, 9 deletions
diff --git a/bench/SKPBench.cpp b/bench/SKPBench.cpp index 2612021510..764119685d 100644 --- a/bench/SKPBench.cpp +++ b/bench/SKPBench.cpp @@ -62,7 +62,7 @@ void SKPBench::onPerCanvasPreDraw(SkCanvas* canvas) { int xTiles = SkScalarCeilToInt(bounds.width() / SkIntToScalar(tileW)); int yTiles = SkScalarCeilToInt(bounds.height() / SkIntToScalar(tileH)); - fSurfaces.setReserve(xTiles * yTiles); + fSurfaces.reserve(xTiles * yTiles); fTileRects.setReserve(xTiles * yTiles); SkImageInfo ii = canvas->imageInfo().makeWH(tileW, tileH); @@ -71,16 +71,16 @@ void SKPBench::onPerCanvasPreDraw(SkCanvas* canvas) { for (int x = bounds.fLeft; x < bounds.fRight; x += tileW) { const SkIRect tileRect = SkIRect::MakeXYWH(x, y, tileW, tileH); *fTileRects.append() = tileRect; - *fSurfaces.push() = canvas->makeSurface(ii).release(); + fSurfaces.emplace_back(canvas->makeSurface(ii)); // Never want the contents of a tile to include stuff the parent // canvas clips out SkRect clip = SkRect::Make(bounds); clip.offset(-SkIntToScalar(tileRect.fLeft), -SkIntToScalar(tileRect.fTop)); - fSurfaces.top()->getCanvas()->clipRect(clip); + fSurfaces.back()->getCanvas()->clipRect(clip); - fSurfaces.top()->getCanvas()->setMatrix(canvas->getTotalMatrix()); - fSurfaces.top()->getCanvas()->scale(fScale, fScale); + fSurfaces.back()->getCanvas()->setMatrix(canvas->getTotalMatrix()); + fSurfaces.back()->getCanvas()->scale(fScale, fScale); } } } @@ -92,10 +92,9 @@ void SKPBench::onPerCanvasPostDraw(SkCanvas* canvas) { sk_sp<SkImage> image(fSurfaces[i]->makeImageSnapshot()); canvas->drawImage(image, SkIntToScalar(fTileRects[i].fLeft), SkIntToScalar(fTileRects[i].fTop)); - SkSafeSetNull(fSurfaces[i]); } - fSurfaces.rewind(); + fSurfaces.reset(); fTileRects.rewind(); } diff --git a/bench/SKPBench.h b/bench/SKPBench.h index 2874bff8b0..44ebc6fd85 100644 --- a/bench/SKPBench.h +++ b/bench/SKPBench.h @@ -43,7 +43,7 @@ protected: virtual void drawPicture(); const SkPicture* picture() const { return fPic.get(); } - const SkTDArray<SkSurface*>& surfaces() const { return fSurfaces; } + const SkTArray<sk_sp<SkSurface>, true>& surfaces() const { return fSurfaces; } const SkTDArray<SkIRect>& tileRects() const { return fTileRects; } private: @@ -54,7 +54,7 @@ private: SkString fUniqueName; const bool fUseMultiPictureDraw; - SkTDArray<SkSurface*> fSurfaces; // for MultiPictureDraw + SkTArray<sk_sp<SkSurface>, true> fSurfaces; // for MultiPictureDraw SkTDArray<SkIRect> fTileRects; // for MultiPictureDraw const bool fDoLooping; |