diff options
| author |  mtklein <mtklein@google.com> | 2014-09-17 06:58:39 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2014-09-17 06:58:39 -0700 |
| commit | 963504bd0a8ced7e1177ae136da03a9cc343d886 (patch) | |
| tree | 60549931ef677b5ae55a7f874b03d56f3c19098a /bench | |
| parent | b0a35f7c5d2c4bfeb601e3ac43f412d202a25292 (diff) | |
Revert of nanobench: lazily decode bitmaps from SKPs (patchset #1 id:1 of https://codereview.chromium.org/572933006/)
Reason for revert:
skia:2944
Original issue's description:
> nanobench: lazily decode bitmaps from SKPs
>
> This makes it considerably cheaper to run SKP recording benchmarks, without
> affecting their measurements and without really affecting SKP playback
> benchmarks at all.
>
> On my machine, running out/Release/nanobench --match skp --config nondrendering
> drops in run time from 6.7s to 2.5s, and the peak RAM usage drops from 129M to 50M.
>
> I'm strongly considering making this lazy decoding the default.
>
> BUG=skia:2944
>
> Committed: https://skia.googlesource.com/skia/+/d664c21a38de98d8db210c46f7a8c4187f1534da
R=robertphillips@google.com, mtklein@chromium.org
TBR=mtklein@chromium.org, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2944
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/554583004
Diffstat (limited to 'bench')
| -rw-r--r-- | bench/nanobench.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/bench/nanobench.cpp b/bench/nanobench.cpp index eff0b2f782..67646c2667 100644 --- a/bench/nanobench.cpp +++ b/bench/nanobench.cpp @@ -10,7 +10,6 @@ #include "Benchmark.h" #include "CrashHandler.h" #include "GMBench.h" -#include "LazyDecodeBitmap.h" #include "ProcStats.h" #include "ResultsWriter.h" #include "RecordingBench.h" @@ -451,7 +450,7 @@ public: return false; } - pic->reset(SkPicture::CreateFromStream(stream.get(), sk_tools::LazyDecodeBitmap)); + pic->reset(SkPicture::CreateFromStream(stream.get())); if (pic->get() == NULL) { SkDebugf("Could not read %s as an SkPicture.\n", path); return false; |