aboutsummaryrefslogtreecommitdiffhomepage
path: root/bench
diff options
context:
space:
mode:
authorGravatar reed <reed@google.com>2014-10-10 09:09:52 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2014-10-10 09:09:52 -0700
commit5324978a88677ac6b758324321816427814e7793 (patch)
treef053d9cc019866c5e7dcb14fa373fe6d2847f2e6 /bench
parente817dbb889b6ef1a811c2c3e6b405ad5c11d6758 (diff)
detect --loops is < 0 and interpret that as running forever (mostly)
Diffstat (limited to 'bench')
-rw-r--r--bench/nanobench.cpp18
1 files changed, 15 insertions, 3 deletions
diff --git a/bench/nanobench.cpp b/bench/nanobench.cpp
index 65cef8989e..d06d75358d 100644
--- a/bench/nanobench.cpp
+++ b/bench/nanobench.cpp
@@ -35,7 +35,7 @@
__SK_FORCE_IMAGE_DECODER_LINKING;
-static const int kAutoTuneLoops = -1;
+static const int kAutoTuneLoops = 0;
static const int kDefaultLoops =
#ifdef SK_DEBUG
@@ -114,6 +114,14 @@ static double estimate_timer_overhead() {
return overhead / FLAGS_overheadLoops;
}
+static int detect_forever_loops(int loops) {
+ // look for a magic run-forever value
+ if (loops < 0) {
+ loops = SK_MaxS32;
+ }
+ return loops;
+}
+
static int clamp_loops(int loops) {
if (loops < 1) {
SkDebugf("ERROR: clamping loops from %d to 1.\n", loops);
@@ -193,8 +201,10 @@ static int cpu_bench(const double overhead, Benchmark* bench, SkCanvas* canvas,
const double numer = overhead / FLAGS_overheadGoal - overhead;
const double denom = bench_plus_overhead - overhead;
loops = (int)ceil(numer / denom);
+ loops = clamp_loops(loops);
+ } else {
+ loops = detect_forever_loops(loops);
}
- loops = clamp_loops(loops);
for (int i = 0; i < FLAGS_samples; i++) {
samples[i] = time(loops, bench, canvas, NULL) / loops;
@@ -228,11 +238,13 @@ static int gpu_bench(SkGLContext* gl,
// We've overshot at least a little. Scale back linearly.
loops = (int)ceil(loops * FLAGS_gpuMs / elapsed);
+ loops = clamp_loops(loops);
// Might as well make sure we're not still timing our calibration.
SK_GL(*gl, Finish());
+ } else {
+ loops = detect_forever_loops(loops);
}
- loops = clamp_loops(loops);
// Pretty much the same deal as the calibration: do some warmup to make
// sure we're timing steady-state pipelined frames.