aboutsummaryrefslogtreecommitdiffhomepage
path: root/bench
diff options
context:
space:
mode:
authorGravatar Ben Wagner <bungeman@google.com>2016-11-03 14:40:50 -0400
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2016-11-03 19:03:40 +0000
commit145dbcd165d9d27298eb8888bc240e2d06a95464 (patch)
tree461ac2a3fe607bdf1d72fd72ae9451a58490a1bc /bench
parentb1c7f88df9ec40b4efb52d314304adfbaf95697c (diff)
Remove SkAutoTDelete.
Replace with std::unique_ptr. Change-Id: I5806cfbb30515fcb20e5e66ce13fb5f3b8728176 Reviewed-on: https://skia-review.googlesource.com/4381 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
Diffstat (limited to 'bench')
-rw-r--r--bench/AndroidCodecBench.cpp4
-rw-r--r--bench/BitmapRegionDecoderBench.h2
-rw-r--r--bench/CodecBench.cpp6
-rw-r--r--bench/ColorCodecBench.cpp4
-rw-r--r--bench/GrMemoryPoolBench.cpp2
-rw-r--r--bench/PDFBench.cpp2
-rw-r--r--bench/PicturePlaybackBench.cpp4
-rw-r--r--bench/RectanizerBench.cpp2
-rw-r--r--bench/nanobench.cpp22
9 files changed, 24 insertions, 24 deletions
diff --git a/bench/AndroidCodecBench.cpp b/bench/AndroidCodecBench.cpp
index 97e1176044..e0680bd9b4 100644
--- a/bench/AndroidCodecBench.cpp
+++ b/bench/AndroidCodecBench.cpp
@@ -29,7 +29,7 @@ bool AndroidCodecBench::isSuitableFor(Backend backend) {
}
void AndroidCodecBench::onDelayedSetup() {
- SkAutoTDelete<SkAndroidCodec> codec(SkAndroidCodec::NewFromData(fData));
+ std::unique_ptr<SkAndroidCodec> codec(SkAndroidCodec::NewFromData(fData));
SkISize scaledSize = codec->getSampledDimensions(fSampleSize);
fInfo = codec->getInfo().makeWH(scaledSize.width(), scaledSize.height())
@@ -42,7 +42,7 @@ void AndroidCodecBench::onDelayedSetup() {
}
void AndroidCodecBench::onDraw(int n, SkCanvas* canvas) {
- SkAutoTDelete<SkAndroidCodec> codec;
+ std::unique_ptr<SkAndroidCodec> codec;
SkAndroidCodec::AndroidOptions options;
options.fSampleSize = fSampleSize;
for (int i = 0; i < n; i++) {
diff --git a/bench/BitmapRegionDecoderBench.h b/bench/BitmapRegionDecoderBench.h
index 2fb56ad2c9..30990557b2 100644
--- a/bench/BitmapRegionDecoderBench.h
+++ b/bench/BitmapRegionDecoderBench.h
@@ -35,7 +35,7 @@ protected:
private:
SkString fName;
- SkAutoTDelete<SkBitmapRegionDecoder> fBRD;
+ std::unique_ptr<SkBitmapRegionDecoder> fBRD;
sk_sp<SkData> fData;
const SkColorType fColorType;
const uint32_t fSampleSize;
diff --git a/bench/CodecBench.cpp b/bench/CodecBench.cpp
index 9bd404db55..a1788ee0cc 100644
--- a/bench/CodecBench.cpp
+++ b/bench/CodecBench.cpp
@@ -26,7 +26,7 @@ CodecBench::CodecBench(SkString baseName, SkData* encoded, SkColorType colorType
alpha_type_to_str(alphaType));
#ifdef SK_DEBUG
// Ensure that we can create an SkCodec from this data.
- SkAutoTDelete<SkCodec> codec(SkCodec::NewFromData(fData));
+ std::unique_ptr<SkCodec> codec(SkCodec::NewFromData(fData));
SkASSERT(codec);
#endif
}
@@ -40,7 +40,7 @@ bool CodecBench::isSuitableFor(Backend backend) {
}
void CodecBench::onDelayedSetup() {
- SkAutoTDelete<SkCodec> codec(SkCodec::NewFromData(fData));
+ std::unique_ptr<SkCodec> codec(SkCodec::NewFromData(fData));
fInfo = codec->getInfo().makeColorType(fColorType)
.makeAlphaType(fAlphaType)
@@ -50,7 +50,7 @@ void CodecBench::onDelayedSetup() {
}
void CodecBench::onDraw(int n, SkCanvas* canvas) {
- SkAutoTDelete<SkCodec> codec;
+ std::unique_ptr<SkCodec> codec;
SkPMColor colorTable[256];
int colorCount;
SkCodec::Options options;
diff --git a/bench/ColorCodecBench.cpp b/bench/ColorCodecBench.cpp
index 8df7e65beb..50727c7047 100644
--- a/bench/ColorCodecBench.cpp
+++ b/bench/ColorCodecBench.cpp
@@ -34,7 +34,7 @@ bool ColorCodecBench::isSuitableFor(Backend backend) {
}
void ColorCodecBench::decodeAndXform() {
- SkAutoTDelete<SkCodec> codec(SkCodec::NewFromData(fEncoded));
+ std::unique_ptr<SkCodec> codec(SkCodec::NewFromData(fEncoded));
SkASSERT(codec);
#ifdef SK_DEBUG
@@ -61,7 +61,7 @@ void ColorCodecBench::xformOnly() {
}
void ColorCodecBench::onDelayedSetup() {
- SkAutoTDelete<SkCodec> codec(SkCodec::NewFromData(fEncoded));
+ std::unique_ptr<SkCodec> codec(SkCodec::NewFromData(fEncoded));
fSrcInfo = codec->getInfo().makeColorType(kRGBA_8888_SkColorType);
fDstInfo = fSrcInfo;
diff --git a/bench/GrMemoryPoolBench.cpp b/bench/GrMemoryPoolBench.cpp
index 9b60c3cc2c..55ba3e6af0 100644
--- a/bench/GrMemoryPoolBench.cpp
+++ b/bench/GrMemoryPoolBench.cpp
@@ -110,7 +110,7 @@ protected:
enum {
kMaxObjects = 4 * (1 << 10),
};
- SkAutoTDelete<B> objects[kMaxObjects];
+ std::unique_ptr<B> objects[kMaxObjects];
for (int i = 0; i < loops; i++) {
uint32_t idx = r.nextRangeU(0, kMaxObjects-1);
diff --git a/bench/PDFBench.cpp b/bench/PDFBench.cpp
index 1010f74ab5..573353fcab 100644
--- a/bench/PDFBench.cpp
+++ b/bench/PDFBench.cpp
@@ -144,7 +144,7 @@ protected:
}
private:
- SkAutoTDelete<SkStreamAsset> fAsset;
+ std::unique_ptr<SkStreamAsset> fAsset;
};
// Test speed of SkPDFUtils::FloatToDecimal for typical floats that
diff --git a/bench/PicturePlaybackBench.cpp b/bench/PicturePlaybackBench.cpp
index 2b2b6ad1fe..54ecd3c4d6 100644
--- a/bench/PicturePlaybackBench.cpp
+++ b/bench/PicturePlaybackBench.cpp
@@ -163,14 +163,14 @@ public:
SkIPoint onGetSize() override { return SkIPoint::Make(1024,1024); }
void onDelayedSetup() override {
- SkAutoTDelete<SkBBHFactory> factory;
+ std::unique_ptr<SkBBHFactory> factory;
switch (fBBH) {
case kNone: break;
case kRTree: factory.reset(new SkRTreeFactory); break;
}
SkPictureRecorder recorder;
- SkCanvas* canvas = recorder.beginRecording(1024, 1024, factory);
+ SkCanvas* canvas = recorder.beginRecording(1024, 1024, factory.get());
SkRandom rand;
for (int i = 0; i < 10000; i++) {
SkScalar x = rand.nextRangeScalar(0, 1024),
diff --git a/bench/RectanizerBench.cpp b/bench/RectanizerBench.cpp
index 5bc6f11b6f..b282313d1d 100644
--- a/bench/RectanizerBench.cpp
+++ b/bench/RectanizerBench.cpp
@@ -115,7 +115,7 @@ private:
SkString fName;
RectanizerType fRectanizerType;
RectType fRectType;
- SkAutoTDelete<GrRectanizer> fRectanizer;
+ std::unique_ptr<GrRectanizer> fRectanizer;
typedef Benchmark INHERITED;
};
diff --git a/bench/nanobench.cpp b/bench/nanobench.cpp
index 37e3f060bc..0651302d0b 100644
--- a/bench/nanobench.cpp
+++ b/bench/nanobench.cpp
@@ -63,7 +63,7 @@
#include "gl/GrGLUtil.h"
using sk_gpu_test::GrContextFactory;
using sk_gpu_test::TestContext;
- SkAutoTDelete<GrContextFactory> gGrFactory;
+ std::unique_ptr<GrContextFactory> gGrFactory;
#endif
struct GrContextOptions;
@@ -481,7 +481,7 @@ void create_configs(SkTArray<Config>* configs) {
SkCommandLineConfigArray array;
ParseConfigs(FLAGS_config, &array);
for (int i = 0; i < array.count(); ++i) {
- create_config(array[i], configs);
+ create_config(array[i].get(), configs);
}
}
@@ -531,7 +531,7 @@ static Target* is_enabled(Benchmark* bench, const Config& config) {
static bool valid_brd_bench(sk_sp<SkData> encoded, SkColorType colorType, uint32_t sampleSize,
uint32_t minOutputSize, int* width, int* height) {
- SkAutoTDelete<SkBitmapRegionDecoder> brd(
+ std::unique_ptr<SkBitmapRegionDecoder> brd(
SkBitmapRegionDecoder::Create(encoded, SkBitmapRegionDecoder::kAndroidCodec_Strategy));
if (nullptr == brd.get()) {
// This is indicates that subset decoding is not supported for a particular image format.
@@ -683,7 +683,7 @@ public:
}
Benchmark* next() {
- SkAutoTDelete<Benchmark> bench;
+ std::unique_ptr<Benchmark> bench;
do {
bench.reset(this->rawNext());
if (!bench) {
@@ -704,7 +704,7 @@ public:
}
while (fGMs) {
- SkAutoTDelete<skiagm::GM> gm(fGMs->factory()(nullptr));
+ std::unique_ptr<skiagm::GM> gm(fGMs->factory()(nullptr));
fGMs = fGMs->next();
if (gm->runAsBench()) {
fSourceType = "gm";
@@ -816,7 +816,7 @@ public:
continue;
}
sk_sp<SkData> encoded(SkData::MakeFromFileName(path.c_str()));
- SkAutoTDelete<SkCodec> codec(SkCodec::NewFromData(encoded));
+ std::unique_ptr<SkCodec> codec(SkCodec::NewFromData(encoded));
if (!codec) {
// Nothing to time.
SkDebugf("Cannot find codec for %s\n", path.c_str());
@@ -900,7 +900,7 @@ public:
continue;
}
sk_sp<SkData> encoded(SkData::MakeFromFileName(path.c_str()));
- SkAutoTDelete<SkAndroidCodec> codec(SkAndroidCodec::NewFromData(encoded));
+ std::unique_ptr<SkAndroidCodec> codec(SkAndroidCodec::NewFromData(encoded));
if (!codec) {
// Nothing to time.
SkDebugf("Cannot find codec for %s\n", path.c_str());
@@ -1137,7 +1137,7 @@ int nanobench_main() {
}
}
- SkAutoTDelete<ResultsWriter> log(new ResultsWriter);
+ std::unique_ptr<ResultsWriter> log(new ResultsWriter);
if (!FLAGS_outResultsFile.isEmpty()) {
#if defined(SK_RELEASE)
log.reset(new NanoJSONResultsWriter(FLAGS_outResultsFile[0]));
@@ -1204,7 +1204,7 @@ int nanobench_main() {
int runs = 0;
BenchmarkStream benchStream;
while (Benchmark* b = benchStream.next()) {
- SkAutoTDelete<Benchmark> bench(b);
+ std::unique_ptr<Benchmark> bench(b);
if (SkCommandLineFlags::ShouldSkip(FLAGS_match, bench->getUniqueName())) {
continue;
}
@@ -1249,12 +1249,12 @@ int nanobench_main() {
samples.reset();
auto stop = now_ms() + FLAGS_ms;
do {
- samples.push_back(time(loops, bench, target) / loops);
+ samples.push_back(time(loops, bench.get(), target) / loops);
} while (now_ms() < stop);
} else {
samples.reset(FLAGS_samples);
for (int s = 0; s < FLAGS_samples; s++) {
- samples[s] = time(loops, bench, target) / loops;
+ samples[s] = time(loops, bench.get(), target) / loops;
}
}