diff options
| author |  commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-12-03 18:17:16 +0000 |
|---|---|---|
| committer | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-12-03 18:17:16 +0000 |
| commit | 3361471a3504ecd0351ff70f4c42d8d6fee963d4 (patch) | |
| tree | 1886e770069303c70c588c396b2d9c19343e3adc /bench/XfermodeBench.cpp | |
| parent | e3bb3bce3e9c1f3bc8ee779b1b3383c18e560bce (diff) | |
Simplify benchmark internal API.
I'm not quite sure why I wrote such a convoluted API with setLoops()/getLoops().
This replaces it with a loops argument passed to onDraw().
This CL is largely mechanical translation from the old API to the new one.
MathBench used this->getLoops() outside onDraw(), which seems incorrect. I
fixed it.
BUG=
R=djsollen@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/99893003
git-svn-id: http://skia.googlecode.com/svn/trunk@12466 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'bench/XfermodeBench.cpp')
| -rw-r--r-- | bench/XfermodeBench.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/bench/XfermodeBench.cpp b/bench/XfermodeBench.cpp index 41b00e6c70..1910b75b21 100644 --- a/bench/XfermodeBench.cpp +++ b/bench/XfermodeBench.cpp @@ -31,10 +31,10 @@ public: protected: virtual const char* onGetName() SK_OVERRIDE { return fName.c_str(); } - virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { + virtual void onDraw(const int loops, SkCanvas* canvas) SK_OVERRIDE { SkISize size = canvas->getDeviceSize(); SkRandom random; - for (int i = 0; i < this->getLoops(); ++i) { + for (int i = 0; i < loops; ++i) { SkPaint paint; paint.setXfermode(fXfermode.get()); paint.setColor(random.nextU()); @@ -70,8 +70,8 @@ public: protected: virtual const char* onGetName() SK_OVERRIDE { return "xfermode_create"; } - virtual void onDraw(SkCanvas* canvas) SK_OVERRIDE { - for (int outer = 0; outer < this->getLoops() * 10; ++outer) { + virtual void onDraw(const int loops, SkCanvas* canvas) SK_OVERRIDE { + for (int outer = 0; outer < loops * 10; ++outer) { for (int i = 0; i <= SkXfermode::kLastMode; ++i) { SkXfermode* xfer = SkXfermode::Create(SkXfermode::Mode(i)); SkSafeUnref(xfer); |