diff options
| author |  commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-03-10 10:51:58 +0000 |
|---|---|---|
| committer | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-03-10 10:51:58 +0000 |
| commit | cac5fd597f6e2495f50aaa6bcbe3dadc56f0b977 (patch) | |
| tree | aeeee764feb84da585a469d005bfaf0e4a69bc13 /bench/MorphologyBench.cpp | |
| parent | b471a32460a44043e1f00d28cbefc87579dc30c5 (diff) | |
Factory methods for heap-allocated SkImageFilter objects.
This is part of an effort to ensure that all SkPaint effects can only be
allocated on the heap.
This patch makes the constructors of SkImageFilter and its subclasses non-public
and instead provides factory methods for creating these objects on the heap. We
temporarily keep constructor of publicly visible classes public behind a flag.
BUG=skia:2187
R=scroggo@google.com, mtklein@chromium.org, reed@google.com, senorblanco@google.com, senorblanco@chromium.org, bsalomon@google.com, sugoi@chromium.org, zork@chromium.org
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/182983003
git-svn-id: http://skia.googlecode.com/svn/trunk@13718 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'bench/MorphologyBench.cpp')
| -rw-r--r-- | bench/MorphologyBench.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/bench/MorphologyBench.cpp b/bench/MorphologyBench.cpp index 0bf689eff6..a32bca620a 100644 --- a/bench/MorphologyBench.cpp +++ b/bench/MorphologyBench.cpp @@ -66,12 +66,12 @@ protected: SkMorphologyImageFilter* mf = NULL; switch (fStyle) { case kDilate_MT: - mf = new SkDilateImageFilter(SkScalarFloorToInt(fRadius), - SkScalarFloorToInt(fRadius)); + mf = SkDilateImageFilter::Create(SkScalarFloorToInt(fRadius), + SkScalarFloorToInt(fRadius)); break; case kErode_MT: - mf = new SkErodeImageFilter(SkScalarFloorToInt(fRadius), - SkScalarFloorToInt(fRadius)); + mf = SkErodeImageFilter::Create(SkScalarFloorToInt(fRadius), + SkScalarFloorToInt(fRadius)); break; } paint.setImageFilter(mf)->unref(); |