diff options
| author |  humper@google.com <humper@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-01-07 16:47:43 +0000 |
|---|---|---|
| committer | humper@google.com <humper@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2013-01-07 16:47:43 +0000 |
| commit | 05af1afd429808913683da75644e48bece12e820 (patch) | |
| tree | b7f0ec33f2cbbb9312deb9e0e566c8bea4a97320 /bench/Matrix44Bench.cpp | |
| parent | 30454293fd4fae81238c582c18232692bff32b1e (diff) | |
eliminate all warnings in non-thirdparty code on mac
Most of these issues were due to functions whose definitions appear in header files; I changed those functions to be 'static inline' instead of just 'static' or 'inline', which kills the warning for such functions.
Other functions that were static or anonymous-namespaced but were unused in cpp files were probably called at some point but are no longer; someone who knows more than I do should probably scrub all the functions I either deleted or #if 0'ed out and make sure that the right thing is happening here.
Lots of unused variables removed, and one nasty const issue handled.
There remains a single warning in thirdparty/externals/cityhash/src/city.cc on line 146 related to a signed/unsigned mismatch. I don't know if we have control over this library so I didn't fix this one, but perhaps someone could do something about that one.
BUG=
Review URL: https://codereview.appspot.com/7067044
git-svn-id: http://skia.googlecode.com/svn/trunk@7051 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'bench/Matrix44Bench.cpp')
| -rw-r--r-- | bench/Matrix44Bench.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/bench/Matrix44Bench.cpp b/bench/Matrix44Bench.cpp index 31525d265f..ce5d99de7b 100644 --- a/bench/Matrix44Bench.cpp +++ b/bench/Matrix44Bench.cpp @@ -48,9 +48,9 @@ public: protected: virtual void performTest() { for (int i = 0; i < 10; ++i) { - fM0 == fM1; - fM1 == fM2; - fM2 == fM0; + (void) (fM0 == fM1); + (void) (fM1 == fM2); + (void) (fM2 == fM0); } } private: |